From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46511) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XONyr-000515-UD for qemu-devel@nongnu.org; Mon, 01 Sep 2014 05:33:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XONyl-00074Z-NB for qemu-devel@nongnu.org; Mon, 01 Sep 2014 05:32:57 -0400 Received: from lputeaux-656-01-25-125.w80-12.abo.wanadoo.fr ([80.12.84.125]:38296 helo=paradis.irqsave.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XONyl-00074S-HW for qemu-devel@nongnu.org; Mon, 01 Sep 2014 05:32:51 -0400 Date: Mon, 1 Sep 2014 11:32:04 +0200 From: =?iso-8859-1?Q?Beno=EEt?= Canet Message-ID: <20140901093203.GJ15537@irqsave.net> References: <1409557394-11853-1-git-send-email-namei.unix@gmail.com> <1409557394-11853-6-git-send-email-namei.unix@gmail.com> <20140901083526.GF15537@irqsave.net> <20140901092609.GE720@ubuntu-trusty> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20140901092609.GE720@ubuntu-trusty> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 5/8] quorum: fix quorum_aio_cancel() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Liu Yuan Cc: =?iso-8859-1?Q?Beno=EEt?= Canet , Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi The Monday 01 Sep 2014 =E0 17:26:09 (+0800), Liu Yuan wrote : > On Mon, Sep 01, 2014 at 10:35:27AM +0200, Beno=EEt Canet wrote: > > The Monday 01 Sep 2014 =E0 15:43:11 (+0800), Liu Yuan wrote : > > > For a fifo read pattern, we only have one running aio > >=20 > > >(possible other cases that has less number than num_children in the = future) > > I have trouble understanding this part of the commit message could yo= u try > > to clarify it ? >=20 > Until this patch, we have two cases, read single or read all. But later= patch > allow VMs to continue if some devices are down. So the discrete number = 1 and N > becomes a range [1, N], that is possible running requests are from 1 to= N. Why not=20 (In some other cases some children of the num_children BDS could be disab= led reducing the number of requests needed) ? >=20 > Thanks > Yuan