From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49534)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <namei.unix@gmail.com>) id 1XOOCd-0006Hn-VN
	for qemu-devel@nongnu.org; Mon, 01 Sep 2014 05:47:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <namei.unix@gmail.com>) id 1XOOCU-0003ie-Ub
	for qemu-devel@nongnu.org; Mon, 01 Sep 2014 05:47:11 -0400
Received: from mail-pa0-x22f.google.com ([2607:f8b0:400e:c03::22f]:49386)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <namei.unix@gmail.com>) id 1XOOCU-0003iX-N9
	for qemu-devel@nongnu.org; Mon, 01 Sep 2014 05:47:02 -0400
Received: by mail-pa0-f47.google.com with SMTP id hz1so11824681pad.6
	for <qemu-devel@nongnu.org>; Mon, 01 Sep 2014 02:47:01 -0700 (PDT)
Date: Mon, 1 Sep 2014 17:46:56 +0800
From: Liu Yuan <namei.unix@gmail.com>
Message-ID: <20140901094656.GI720@ubuntu-trusty>
References: <1409557394-11853-1-git-send-email-namei.unix@gmail.com>
	<1409557394-11853-6-git-send-email-namei.unix@gmail.com>
	<20140901083526.GF15537@irqsave.net>
	<20140901092609.GE720@ubuntu-trusty>
	<20140901093203.GJ15537@irqsave.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20140901093203.GJ15537@irqsave.net>
Subject: Re: [Qemu-devel] [PATCH 5/8] quorum: fix quorum_aio_cancel()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

On Mon, Sep 01, 2014 at 11:32:04AM +0200, Benoît Canet wrote:
> The Monday 01 Sep 2014 à 17:26:09 (+0800), Liu Yuan wrote :
> > On Mon, Sep 01, 2014 at 10:35:27AM +0200, Benoît Canet wrote:
> > > The Monday 01 Sep 2014 à 15:43:11 (+0800), Liu Yuan wrote :
> > > > For a fifo read pattern, we only have one running aio
> > > 
> > > >(possible other cases that has less number than num_children in the future)
> > > I have trouble understanding this part of the commit message could you try
> > > to clarify it ?
> > 
> > Until this patch, we have two cases, read single or read all. But later patch
> > allow VMs to continue if some devices are down. So the discrete number 1 and N
> > becomes a range [1, N], that is possible running requests are from 1 to N.
> 
> Why not 
> 
> (In some other cases some children of the num_children BDS could be disabled
> reducing the number of requests needed) ?
> 

Sounds better, I'll take yours, thanks!

Yuan