From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58375) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XOTRf-0005Gf-Qj for qemu-devel@nongnu.org; Mon, 01 Sep 2014 11:23:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XOTRW-0005X8-Pr for qemu-devel@nongnu.org; Mon, 01 Sep 2014 11:23:03 -0400 Received: from mail-wi0-x232.google.com ([2a00:1450:400c:c05::232]:59918) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XOTRW-0005X2-F9 for qemu-devel@nongnu.org; Mon, 01 Sep 2014 11:22:54 -0400 Received: by mail-wi0-f178.google.com with SMTP id r20so6332496wiv.17 for ; Mon, 01 Sep 2014 08:22:53 -0700 (PDT) Date: Mon, 1 Sep 2014 16:22:51 +0100 From: Stefan Hajnoczi Message-ID: <20140901152251.GC22346@stefanha-thinkpad.redhat.com> References: <1409308848-5245-1-git-send-email-marc.mari.barcelo@gmail.com> <1409308848-5245-3-git-send-email-marc.mari.barcelo@gmail.com> <20140829154936.GA19824@stefanha-thinkpad.redhat.com> <5400A369.3020403@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="6zdv2QT/q3FMhpsV" Content-Disposition: inline In-Reply-To: <5400A369.3020403@redhat.com> Subject: Re: [Qemu-devel] [PATCH v7 2/7] tests: Add virtio device initialization List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Marc =?iso-8859-1?Q?Mar=ED?= , qemu-devel@nongnu.org, Stefan Hajnoczi --6zdv2QT/q3FMhpsV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 29, 2014 at 05:59:37PM +0200, Paolo Bonzini wrote: > Il 29/08/2014 17:49, Stefan Hajnoczi ha scritto: > > for (i =3D 0; i < 8; ++i) { > > quad.bytes[i] =3D qpci_io_readb(dev->pdev, addr + i); > > } > > if (qtest_big_endian() !=3D qtest_host_endian()) { > > quad.u64 =3D bswap64(quad.u64); > > } > > return quard.u64; >=20 > Why not keep the logic in Marc's patch, just replacing the union with OR > and shift? That's fine too. Stefan --6zdv2QT/q3FMhpsV Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUBI9LAAoJEJykq7OBq3PIEyMIAIdcdFdEtKXB4lGOdTtW7b5Z SG6W0mS2j0Mp0F3HppQtj0pxGZiTvNG5aoZZQV6+sULu4Y0dHdxLWI+uK+YuvVRu djlzgYBWIdlkbssi0kVADOeeJ8KLG98d/6ph0+U4CH2d0s80uxajm4hasVKr73+X s3frYaL1BoCRXpvE56H7ekVoFOJf3KpRxAneoh8HvPqExxri9C2VbsAV896UPnmr LjlqiYOEmW0Or2TTdLVRl3/xAAV3Y3v2VW1vbLrmyP2BU0NP0EVGiyVC69T8x8Ab vbFjP3TNH3sz9UywSrzjB+/1Qwb1sprhCtzKD5AL97H0DBxywXioShfGn2ij05A= =Ikqp -----END PGP SIGNATURE----- --6zdv2QT/q3FMhpsV--