From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43558)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1XOclD-00041k-GJ
	for qemu-devel@nongnu.org; Mon, 01 Sep 2014 21:19:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1XOcl7-0005Ns-6O
	for qemu-devel@nongnu.org; Mon, 01 Sep 2014 21:19:51 -0400
Received: from mx1.redhat.com ([209.132.183.28]:22545)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1XOcl6-0005Nm-VL
	for qemu-devel@nongnu.org; Mon, 01 Sep 2014 21:19:45 -0400
Date: Tue, 2 Sep 2014 09:19:39 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20140902011939.GA5993@T430.redhat.com>
References: <1409567710-26217-1-git-send-email-famz@redhat.com>
	<CAFEAcA9T1NPpVe1UMCwKXSiaTFQaxzGt86vK1wT2_+72knvmCA@mail.gmail.com>
	<5404584D.9000702@redhat.com>
	<CAFEAcA8_ycWbhi0K4qSTqU0xMbETQ1SLw-A9keBi1SJOYeLoug@mail.gmail.com>
	<540460C1.6090806@redhat.com>
	<CAFEAcA_7L3-_abbx=6YffXvPY83Uhs4xyGZEGv=WKmsvUxHHgg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFEAcA_7L3-_abbx=6YffXvPY83Uhs4xyGZEGv=WKmsvUxHHgg@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH v2] rules.mak: Fix DSO build by pulling in
	archive symbols
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>

On Mon, 09/01 13:07, Peter Maydell wrote:
> On 1 September 2014 13:04, Paolo Bonzini <pbonzini@redhat.com> wrote:
> > Il 01/09/2014 13:46, Peter Maydell ha scritto:
> >> So we could fix this by not compiling empty files...
> >
> > Easy for int128, even easier for getauxval (it's not a fastpath, so we
> > can move the "always return 0" version from include/qemu/osdep.h to
> > util/getauxval.c).
> >
> > I'm not sure how to detect that there generated-tracers.c is empty.
> > Stefan, is it used by anything except $(CONFIG_TRACE_SIMPLE)?
> 
> You could always put in a dummy function that isn't actually
> used by anything.
> 
> >> ranlib doesn't like that either (this one's a warning we've had for
> >> a long time):
> >
> > Given this, do you consider th a blocker for this patch?
> 
> The ranlib warnings are comparatively clear and only happen
> when we link the .a file; the warnings we get out of nm are
> rather uglier and more confusing and produced at every final
> binary link. I'd certainly prefer it if we could fix them, but I
> guess I won't absolutely insist on it.
> 

Thanks both of you for tracking down the problem. Let's add 2>/dev/null to
suppress the warning.

Fam