From: Stefan Hajnoczi <stefanha@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
benoit.canet@irqsave.net, qemu-devel@nongnu.org,
armbru@redhat.com, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH v5] block: Introduce "null" drivers
Date: Tue, 2 Sep 2014 10:46:21 +0100 [thread overview]
Message-ID: <20140902094621.GD29067@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1409563324-28205-1-git-send-email-famz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 327 bytes --]
On Mon, Sep 01, 2014 at 05:22:04PM +0800, Fam Zheng wrote:
> +{ 'type': 'BlockdevOptionsNull',
> + 'base': 'BlockdevOptionsFile',
> + 'data': { '*size': 'int' } }
Why inherit from BlockdevOptionsFile?
No other blockdev options type does that. Unless there is a real
inheritance relationship, please don't do this.
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-09-02 9:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-01 9:22 [Qemu-devel] [PATCH v5] block: Introduce "null" drivers Fam Zheng
2014-09-02 9:46 ` Stefan Hajnoczi [this message]
2014-09-03 10:10 ` Kevin Wolf
2014-09-03 10:29 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140902094621.GD29067@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=armbru@redhat.com \
--cc=benoit.canet@irqsave.net \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).