From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37560)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1XOkfh-0002Vx-Le
	for qemu-devel@nongnu.org; Tue, 02 Sep 2014 05:46:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1XOkfW-0000Vs-2a
	for qemu-devel@nongnu.org; Tue, 02 Sep 2014 05:46:41 -0400
Received: from mx1.redhat.com ([209.132.183.28]:29596)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1XOkfV-0000Up-RU
	for qemu-devel@nongnu.org; Tue, 02 Sep 2014 05:46:30 -0400
Date: Tue, 2 Sep 2014 10:46:21 +0100
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20140902094621.GD29067@stefanha-thinkpad.redhat.com>
References: <1409563324-28205-1-git-send-email-famz@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="at6+YcpfzWZg/htY"
Content-Disposition: inline
In-Reply-To: <1409563324-28205-1-git-send-email-famz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v5] block: Introduce "null" drivers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, benoit.canet@irqsave.net, qemu-devel@nongnu.org, armbru@redhat.com, pbonzini@redhat.com


--at6+YcpfzWZg/htY
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Sep 01, 2014 at 05:22:04PM +0800, Fam Zheng wrote:
> +{ 'type': 'BlockdevOptionsNull',
> +  'base': 'BlockdevOptionsFile',
> +  'data': { '*size': 'int' } }

Why inherit from BlockdevOptionsFile?

No other blockdev options type does that.  Unless there is a real
inheritance relationship, please don't do this.

Stefan

--at6+YcpfzWZg/htY
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJUBZHtAAoJEJykq7OBq3PIrPQH/izz7cZDpuWnl+AG8+Pr0yIJ
tu9gsgpH9V7Oip58FDV++KcqhG1ONKzvp2ZRogz7ZtGkCXsDE4YF2PEiX5QF3xsA
Hr4l0oLjHXe1RtwL0d6IQSF0mm4p36kk/iK29AJTY3MIRpjDzXo0kiHO+GRTHUf8
Xanpdpjlr15xC3BR6tm7lhKHjWkDS1WmW2EOZdScLkrVYm2l5O0a/VpKraSzefik
eTtB/1D9jriG/8GhAe6oFwulkmbmIAkxZCd+IGzFMzLpG0citYeNvw1yCJVUfFck
qZJf3wIZ/ELOnArp+hQS1PLN+IeYm0Rv0DeTggY970Spb+DZB8lht39WAKYpksI=
=uDex
-----END PGP SIGNATURE-----

--at6+YcpfzWZg/htY--