From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41250) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XOkqT-0006qW-14 for qemu-devel@nongnu.org; Tue, 02 Sep 2014 05:57:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XOkqM-00052Y-SE for qemu-devel@nongnu.org; Tue, 02 Sep 2014 05:57:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43657) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XOkqM-00052R-KF for qemu-devel@nongnu.org; Tue, 02 Sep 2014 05:57:42 -0400 Date: Tue, 2 Sep 2014 10:57:35 +0100 From: Stefan Hajnoczi Message-ID: <20140902095735.GE29067@stefanha-thinkpad.redhat.com> References: <1409566080-6313-1-git-send-email-marc.mari.barcelo@gmail.com> <1409566080-6313-6-git-send-email-marc.mari.barcelo@gmail.com> <20140901180909.6d404d39@bahia.local> <20140901182734.6de2abc7@crunchbang> <20140901231137.649d7bb8@crunchbang> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="pY3vCvL1qV+PayAL" Content-Disposition: inline In-Reply-To: <20140901231137.649d7bb8@crunchbang> Subject: Re: [Qemu-devel] [PATCH v8 5/7] libqos: Added test case for configuration changes in virtio-blk test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marc =?iso-8859-1?Q?Mar=ED?= Cc: Paolo Bonzini , qemu-devel@nongnu.org --pY3vCvL1qV+PayAL Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 01, 2014 at 11:11:37PM +0200, Marc Mar=ED wrote: > El Mon, 1 Sep 2014 18:27:34 +0200 > Marc Mar=ED escribi=F3: > > El Mon, 1 Sep 2014 18:09:09 +0200 > > Greg Kurz escribi=F3: > > > On Mon, 1 Sep 2014 12:07:58 +0200 > > > Marc Mar=ED wrote: > > > > Reviewed-by: Stefan Hajnoczi > > > > Signed-off-by: Marc Mar=ED > > > > --- > > >=20 > > > Hi Marc, > > >=20 > > > I gave it a try for various host/target combinations involving ppc64 > > > and x86_64. Here is what I get: > > >=20 > > > | x86_64 | ppc64 | TARGET > > > +------------+-------------+-------- > > > x86_64 | OK | assert (1) | > > > --------+------------+-------------+ > > > ppc64 | assert (2) | assert (1) | > > > --------+------------+-------------+ > > > ppc64le | OK | assert (1) | > > > --------+------------+-------------+ > > > HOST | > > >=20 > > > where OK means: > > >=20 > > > /virtio/blk/pci/basic: OK > > > /virtio/blk/pci/indirect: OK > > > /virtio/blk/pci/config: OK > > > /virtio/blk/pci/msix: OK > > > /virtio/blk/pci/idx: OK > > >=20 > > > and assert (1) is: > > >=20 > > > tests/virtio-blk-test.c:87:virtio_blk_init: assertion failed: > > > (dev !=3D NULL) > > >=20 > > > and assert (2) is: > > >=20 > > > tests/virtio-blk-test.c:171:pci_basic: assertion failed (status =3D=3D > > > 0): (2 =3D=3D 0) > > >=20 > > > I will investigate further but the first column in the array ^^ > > > seems to indicate that there's some endianness bug. > > >=20 > > > Cheers. > > >=20 > > > -- > > > Greg > >=20 > > Hi > >=20 > > I will also investigate. Just add that with assert (2), status > > is 2, which means status is VIRTIO_BLK_S_UNSUPP, which means "request > > unsupported by host". So, for some reason, ppc64 host does not support > > a simple write request. > >=20 > > Thanks for your tests > > Marc >=20 > Hi >=20 > The problem seems to be that it is not implemented. virtio-blk-test is > now using pci-pc, that has the addresses 0xcf8 and 0xcfc hardcoded. > These addresses are the key-value for PCI space, to search for devices, > and I suppose it is specific to i386 and x86_64. >=20 > I also searched information to see how easy it is to add another > architecture and I could not find much information on ppc64, and even > less when mixing ppc64 and PCI. That explains why the ppc64 target column is failing. But x86 target on ppc64 host should still work. Stefan --pY3vCvL1qV+PayAL Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUBZSPAAoJEJykq7OBq3PIKxwIALhTvjUk5+6c784pfUyL6Vhh wMz7QbWEw1vIYPydSm4PY2ppOcpAAo0rT2URiWj1YPX+x03cfw7JNECPbE/QJhTH sbbmKsoC7XFf3zbmaV1skEbVEs0Mo6rxW2wVy86S9Bnk0oYS7XjhdZ9eSlyNy+6o lONwCC6oCsxYjofGAo5yRcHuITybkaUAz48Tl/dFGpS6KMKx5jMSeiNtqZx7dJlS xv3zM5EnznVLoZH+FW8whKv3D7q2Uxgm35pbxIoHGeUUNHaKt1jUXtIk+3UYBd8A wtk1B8KtNcEI/Oy9eNXi8W8gxSi92fjI5U3/IWqwzd0D9cc2q3x4/ri929L/KWk= =4NXk -----END PGP SIGNATURE----- --pY3vCvL1qV+PayAL--