From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49781) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XOlYr-0004Au-N0 for qemu-devel@nongnu.org; Tue, 02 Sep 2014 06:43:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XOlYl-0003wk-8r for qemu-devel@nongnu.org; Tue, 02 Sep 2014 06:43:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22237) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XOlYl-0003wc-18 for qemu-devel@nongnu.org; Tue, 02 Sep 2014 06:43:35 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s82AhXc9013207 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 2 Sep 2014 06:43:34 -0400 Date: Tue, 2 Sep 2014 11:01:55 +0100 From: Stefan Hajnoczi Message-ID: <20140902100155.GF29067@stefanha-thinkpad.redhat.com> References: <1409584287-21844-1-git-send-email-stefanha@redhat.com> <1409584287-21844-3-git-send-email-stefanha@redhat.com> <20140902025253.GB5586@T430.redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="NQTVMVnDVuULnIzU" Content-Disposition: inline In-Reply-To: <20140902025253.GB5586@T430.redhat.com> Subject: Re: [Qemu-devel] [PATCH 2/2] qemu-img: fix rebase src_cache option documentation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: Kevin Wolf , jenelson@redhat.com, qemu-devel@nongnu.org, Max Reitz --NQTVMVnDVuULnIzU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 02, 2014 at 10:52:53AM +0800, Fam Zheng wrote: > On Mon, 09/01 16:11, Stefan Hajnoczi wrote: > > The src_cache option (-T) specifies the cache mode for backing files. > > It applies both the image's old backing file as well as the new backing > > file: > >=20 > > ret =3D bdrv_open(&bs_old_backing, backing_name, NULL, NULL, src_flag= s, > > old_backing_drv, &local_err); > > if (ret) { > > ... > > } > > if (out_baseimg[0]) { > > bs_new_backing =3D bdrv_new("new_backing", &error_abort); > > ret =3D bdrv_open(&bs_new_backing, out_baseimg, NULL, NULL, src_f= lags, > > new_backing_drv, &local_err); > > if (ret) { > > ... > > } > > } > >=20 > > The documentation only mentions the new backing file but it really > > applies to both. > >=20 > > Suggested-by: Jeff Nelson > > Signed-off-by: Stefan Hajnoczi > > --- > > qemu-img.texi | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > diff --git a/qemu-img.texi b/qemu-img.texi > > index 4380d56..7c2df14 100644 > > --- a/qemu-img.texi > > +++ b/qemu-img.texi > > @@ -341,7 +341,7 @@ string), then the image is rebased onto no backing = file (i.e. it will exist > > independently of any backing file). > > =20 > > @var{cache} specifies the cache mode to be used for @var{filename}, wh= ereas > > -@var{src_cache} specifies the cache mode for reading the new backing f= ile. > > +@var{src_cache} specifies the cache mode for reading backing file file= s. >=20 > Is "backing file files" intended, why not just "backing files"? :) Ha! Thanks for spotting that. I managed to typo it. Fixed in v2. Stefan --NQTVMVnDVuULnIzU Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUBZWTAAoJEJykq7OBq3PIATQH/At/1hBc+S+/743em+7HrmqG R016jWBWJf/eOSIdoEne0ToSvdrR+KNbkj4hXCTbvNUZoQ8yl8YIl24I/hjUzD7d sFwjK4WvZ8dwBO1tHwGvrC1bubvxI86ETAgv9uIIPv5L6qRDp00YNixvDYroJ3pj NPf0XCpgJCZJluwSlcXSeEQ/pOqaMsf7cao0NH+FiFwu4YMKZ/waIIM3rPGPKAMK ReijRdzlelUB3vMjJve6LpkXTWySxhB7cANh+nOzBee2Vby6FGrxljHNwgwJrwoD AtjpRXaH59F8QEk2RE4phe2Mw9Gxs7i6TUk8PIsObGVH49w5sbmPaYzMSK5VM7c= =Q4D1 -----END PGP SIGNATURE----- --NQTVMVnDVuULnIzU--