From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55758) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XOpkA-0004go-Jj for qemu-devel@nongnu.org; Tue, 02 Sep 2014 11:11:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XOpk2-0002Wu-UW for qemu-devel@nongnu.org; Tue, 02 Sep 2014 11:11:38 -0400 Received: from e38.co.us.ibm.com ([32.97.110.159]:39040) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XOpk2-0002Wp-P6 for qemu-devel@nongnu.org; Tue, 02 Sep 2014 11:11:30 -0400 Received: from /spool/local by e38.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 2 Sep 2014 09:11:29 -0600 Received: from b03cxnp08028.gho.boulder.ibm.com (b03cxnp08028.gho.boulder.ibm.com [9.17.130.20]) by d03dlp03.boulder.ibm.com (Postfix) with ESMTP id BE26219D803E for ; Tue, 2 Sep 2014 09:11:13 -0600 (MDT) Received: from d03av05.boulder.ibm.com (d03av05.boulder.ibm.com [9.17.195.85]) by b03cxnp08028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id s82FBQGY19595492 for ; Tue, 2 Sep 2014 17:11:26 +0200 Received: from d03av05.boulder.ibm.com (localhost [127.0.0.1]) by d03av05.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s82FBQ4E007754 for ; Tue, 2 Sep 2014 09:11:26 -0600 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Roth In-Reply-To: <87a97rnlfb.fsf@blackfin.pond.sub.org> References: <592b4a2a2b00e21470bec1a2ecf259a64eb285b2.1406703720.git.jan.kiszka@siemens.com> <20140730085732.GA14263@redhat.com> <53D8B6B4.5070302@redhat.com> <87a97rnlfb.fsf@blackfin.pond.sub.org> Message-ID: <20140902151125.16792.32360@loki> Date: Tue, 02 Sep 2014 10:11:25 -0500 Subject: Re: [Qemu-devel] [PATCH 1/3] pc: Fix disabling of vapic for compat PC models List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , Paolo Bonzini Cc: Jan Kiszka , qemu-devel , "Michael S. Tsirkin" Quoting Markus Armbruster (2014-07-30 06:19:36) > Paolo Bonzini writes: > = > > Il 30/07/2014 10:57, Michael S. Tsirkin ha scritto: > >> On Wed, Jul 30, 2014 at 09:01:59AM +0200, Jan Kiszka wrote: > >>> We used to be able to address both the QEMU and the KVM APIC via "api= c". > >>> This doesn't work anymore. So we need to use their parent class to tu= rn > >>> off the vapic on machines that should not expose them. > >>> = > >>> Signed-off-by: Jan Kiszka > >> > >> > >> > >> OK so this is intended for 2.2? > = > If yes, we should cc: qemu-stable. Ping for stable 2.1.1, freeze is on Wednesday > = > >> In that case, how about creating a macro with type name, > >> and using that? This way things don't break if we rename > >> something again. > > > > Don't we have warnings for that now? > = > Warnings don't help much in cases like this: "apic" still exists and has > the property, it's just not the device we want. Macros aren't > foolproof, either. > = > >>> --- > >>> hw/i386/pc_piix.c | 2 +- > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>> = > >>> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c > >>> index 9694f88..73ba77d 100644 > >>> --- a/hw/i386/pc_piix.c > >>> +++ b/hw/i386/pc_piix.c > >>> @@ -645,7 +645,7 @@ static QEMUMachine pc_machine_v1_1 =3D { > >>> .property =3D "class",\ > >>> .value =3D stringify(PCI_CLASS_MEMORY_RAM),\ > >>> },{\ > >>> - .driver =3D "apic",\ > >>> + .driver =3D "apic-common",\ > >>> .property =3D "vapic",\ > >>> .value =3D "off",\ > >>> },{\ > >>> -- = > >>> 1.8.1.1.298.ge7eed54 > = > You could use TYPE_APIC_COMMON here. Including > "hw/i386/apic_internal.h" for it would be not so nice, though.