From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58124) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XOpsT-0000Gt-Tz for qemu-devel@nongnu.org; Tue, 02 Sep 2014 11:20:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XOpsP-0006U5-41 for qemu-devel@nongnu.org; Tue, 02 Sep 2014 11:20:13 -0400 Date: Tue, 2 Sep 2014 18:19:58 +0300 From: "Michael S. Tsirkin" Message-ID: <20140902151958.GA23192@redhat.com> References: <1409659388-9404-1-git-send-email-arei.gonglei@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1409659388-9404-1-git-send-email-arei.gonglei@huawei.com> Subject: Re: [Qemu-devel] [PATCH v5 0/4] Refactor device_set_realized to avoid resource leak. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: arei.gonglei@huawei.com Cc: peter.crosthwaite@xilinx.com, weidong.huang@huawei.com, qemu-stable@nongnu.org, luonengjun@huawei.com, qemu-devel@nongnu.org, peter.huangpeng@huawei.com, imammedo@redhat.com, pbonzini@redhat.com, afaerber@suse.de On Tue, Sep 02, 2014 at 08:03:04PM +0800, arei.gonglei@huawei.com wrote: > From: Gonglei > > after committing > [PATCH v6 0/9] Refactor PCI/SHPC/PCIE hotplug to use a more generic hotplug API Patches 1-3 make sense for qemu-stable? Andreas could you please comment and if yes pick them up and add Cc qemu-stable? 2.1.1 freeze is tomorrow. > If devcie hotplugging failed, will casuse resource leak. > This patch series include address resouce leak and two other issuses. > > v5 -> v4: > - add patch 1/4 'Reviewed-by' tag. > - change patch 2/4, propagate firsh child unrealizing failure, and > change this patch's commit message.(Peter) > > v4 -> v3: > - add patch 2/4.(Thanks for Peter's suggestion) > - rework patch 3/4 based on patch 2/4. > > v3 -> v2: > - add cleanup logic for set bus/child_bus realized/unrealized failed. > - change patch 1/3 commit message, add 'Reviewed-by' tag. > > v2 -> v1: > - rewrite patch 1/3, using error_abort instead of local_err. > - rewrite patch 2/3, add cleanup logic for different error embranchment. > - rewrite title of patch 3/3, and a syntax fix. > > Gonglei (4): > qdev: using error_abort instead of using local_err > qdev: using NULL instead of local_err for qbus_child unrealize > qdev: add cleanup logic in device_set_realized() to avoid resource > leak > pcie: don't assert when hotplug a PCIe device with 'function != 0' > > hw/core/qdev.c | 69 +++++++++++++++++++++++++++++++++++++++++++--------------- > hw/pci/pcie.c | 6 ++++- > 2 files changed, 56 insertions(+), 19 deletions(-) > > -- > 1.7.12.4 >