From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41581)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XOqX4-0003H4-T7
	for qemu-devel@nongnu.org; Tue, 02 Sep 2014 12:02:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XOqX0-0007y0-52
	for qemu-devel@nongnu.org; Tue, 02 Sep 2014 12:02:10 -0400
Date: Tue, 2 Sep 2014 19:01:46 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20140902160146.GA23385@redhat.com>
References: <1409670380-22943-1-git-send-email-mst@redhat.com>
	<1409670380-22943-14-git-send-email-mst@redhat.com>
	<20140902154754.GF29021@gandi.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20140902154754.GF29021@gandi.net>
Subject: Re: [Qemu-devel] [PULL 13/13] vhost_net: start/stop guest notifiers
 properly
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: William Dauchy <william@gandi.net>
Cc: Peter Maydell <peter.maydell@linaro.org>, Jason Wang <jasowang@redhat.com>, qemu-devel@nongnu.org, qemu-stable@nongnu.org, William Dauchy <wdauchy@gmail.com>, Anthony Liguori <aliguori@amazon.com>, "Zhangjie (HZ)" <zhangjie14@huawei.com>

On Tue, Sep 02, 2014 at 05:47:54PM +0200, William Dauchy wrote:
> On Sep02 18:07, Michael S. Tsirkin wrote:
> > From: Jason Wang <jasowang@redhat.com>
> > 
> > commit a9f98bb5ebe6fb1869321dcc58e72041ae626ad8 vhost: multiqueue
> > support changed the order of stopping the device. Previously
> > vhost_dev_stop would disable backend and only afterwards, unset guest
> > notifiers. We now unset guest notifiers while vhost is still
> > active. This can lose interrupts causing guest networking to fail. In
> > particular, this has been observed during migration.
> > 
> > To adapt this, several other changes are needed:
> > - remove the hdev->started assertion in vhost.c since we may want to
> > start the guest notifiers before vhost starts and stop the guest
> > notifiers after vhost is stopped.
> > - introduce the vhost_net_set_vq_index() and call it before setting
> > guest notifiers. This is used to guarantee vhost_net has the correct
> > virtqueue index when setting guest notifiers.
> > 
> > Cc: qemu-stable@nongnu.org
> > Reported-by: "Zhangjie (HZ)" <zhangjie14@huawei.com>
> > Tested-by: William Dauchy <wdauchy@gmail.com>
> 
> please use:
> 
> Tested-by: William Dauchy <william@gandi.net>

It's a pull request so not easy to fix.
I'll do it like that next time.

> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > Signed-off-by: Jason Wang <jasowang@redhat.com>
> > Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> 
> Thanks,
> -- 
> William