From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41119)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XP6VI-0000lD-TY
	for qemu-devel@nongnu.org; Wed, 03 Sep 2014 05:05:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XP6VC-0005Ds-Dy
	for qemu-devel@nongnu.org; Wed, 03 Sep 2014 05:05:24 -0400
Date: Wed, 3 Sep 2014 12:08:32 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20140903090832.GB6792@redhat.com>
References: <1409725530-1425-1-git-send-email-jasowang@redhat.com>
	<20140903085208.GA6781@redhat.com>
	<CABYiri-73okdWx1jcQs2LNeo58rogykyYgdBbgMAFpW+a+cLbg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CABYiri-73okdWx1jcQs2LNeo58rogykyYgdBbgMAFpW+a+cLbg@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] vhost_net: initialize acked_features to a
 safe value during ack
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andrey Korolyov <andrey@xdel.ru>
Cc: Jason Wang <jasowang@redhat.com>, qemu-stable@nongnu.org, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Nikolay Nikolaev <n.nikolaev@virtualopensystems.com>, Michael Roth <mdroth@linux.vnet.ibm.com>

On Wed, Sep 03, 2014 at 12:54:03PM +0400, Andrey Korolyov wrote:
> On Wed, Sep 3, 2014 at 12:52 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
> > On Wed, Sep 03, 2014 at 02:25:30PM +0800, Jason Wang wrote:
> >> commit 2e6d46d77ed328d34a94688da8371bcbe243479b (vhost: add
> >> vhost_get_features and vhost_ack_features) removes the step that
> >> initializes the acked_features to backend_features. This will result an
> >> unexpected value of acked_features which may fail the features setting of
> >> vhost. This patch fixes it by recover this step.
> >>
> >> Cc: Nikolay Nikolaev <n.nikolaev@virtualopensystems.com>
> >> Cc: Andrey Korolyov <andrey@xdel.ru>
> >> Cc: Michael S. Tsirkin <mst@redhat.com>
> >> Cc: Michael Roth <mdroth@linux.vnet.ibm.com>
> >> Cc: qemu-stable@nongnu.org
> >> Signed-off-by: Jason Wang <jasowang@redhat.com>
> >
> > OK I get it and it's correct, but I think it's better to
> > put the initialization in core vhost code.
> > Patch sent, could you confirm that it works for you please?
> >
> >> ---
> >>  hw/net/vhost_net.c | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c
> >> index f87c798..b1d4b1f 100644
> >> --- a/hw/net/vhost_net.c
> >> +++ b/hw/net/vhost_net.c
> >> @@ -115,6 +115,7 @@ unsigned vhost_net_get_features(struct vhost_net *net, unsigned features)
> >>
> >>  void vhost_net_ack_features(struct vhost_net *net, unsigned features)
> >>  {
> >> +    net->dev.acked_features = net->dev.backend_features;
> >>      vhost_ack_features(&net->dev, vhost_net_get_feature_bits(net), features);
> >>  }
> >>
> >> --
> >> 1.8.3.1
> 
> Yes, this patch fixes both issues with vhost subsystem for me.

Sorry posted a different one - can you pls try it out?
We still have a bug somewhere in error handling I suspect, so
let's keep debugging.