qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: benoit.canet@irqsave.net, qemu-devel@nongnu.org,
	armbru@redhat.com, Stefan Hajnoczi <stefanha@redhat.com>,
	pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH v5] block: Introduce "null" drivers
Date: Wed, 3 Sep 2014 12:10:38 +0200	[thread overview]
Message-ID: <20140903101038.GG7717@noname.str.redhat.com> (raw)
In-Reply-To: <1409563324-28205-1-git-send-email-famz@redhat.com>

Am 01.09.2014 um 11:22 hat Fam Zheng geschrieben:
> This is an analogue to Linux null_blk. It can be used for testing or
> benchmarking block device emulation and general block layer
> functionalities such as coroutines and throttling, where disk IO is not
> necessary or wanted.
> 
> Use null-aio:// for AIO version, and null-co:// for coroutine version.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> Reviewed-by: Benoît Canet <benoit.canet@nodalink.com>

> +static BlockDriver bdrv_null_co = {
> +    .format_name            = "null-co",
> +    .protocol_name          = "null-co",
> +    .instance_size          = sizeof(BDRVNullState),
> +
> +    .bdrv_file_open         = null_file_open,
> +    .bdrv_close             = null_close,
> +    .bdrv_getlength         = null_getlength,
> +
> +    .bdrv_read              = null_co_read,
> +    .bdrv_write             = null_co_write,

Any reason not to use the native .bdrv_co_readv/writev interfaces
instead of the old, emulated versions that involve a bounce buffer?

> +    .bdrv_co_flush_to_disk  = null_co_flush,
> +};

Kevin

  parent reply	other threads:[~2014-09-03 11:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-01  9:22 [Qemu-devel] [PATCH v5] block: Introduce "null" drivers Fam Zheng
2014-09-02  9:46 ` Stefan Hajnoczi
2014-09-03 10:10 ` Kevin Wolf [this message]
2014-09-03 10:29   ` Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140903101038.GG7717@noname.str.redhat.com \
    --to=kwolf@redhat.com \
    --cc=armbru@redhat.com \
    --cc=benoit.canet@irqsave.net \
    --cc=famz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).