From: Stefan Hajnoczi <stefanha@gmail.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Anthony Liguori <aliguori@amazon.com>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] virtio-net: don't run bh on vm stopped
Date: Wed, 3 Sep 2014 11:45:57 +0100 [thread overview]
Message-ID: <20140903104557.GG28095@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1409667966-16907-1-git-send-email-mst@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 770 bytes --]
On Tue, Sep 02, 2014 at 05:26:12PM +0300, Michael S. Tsirkin wrote:
> commit 783e7706937fe15523b609b545587a028a2bdd03
> virtio-net: stop/start bh when appropriate
>
> is incomplete: BH might execute within the same main loop iteration but
> after vmstop, so in theory, we might trigger an assertion.
> I was unable to reproduce this in practice,
> but it seems clear enough that the potential is there, so worth fixing.
>
> Cc: qemu-stable@nongnu.org
> Reported-by: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> hw/net/virtio-net.c | 14 ++++++++++++--
> 1 file changed, 12 insertions(+), 2 deletions(-)
Thanks, applied to my net tree:
https://github.com/stefanha/qemu/commits/net
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-09-03 10:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 14:26 [Qemu-devel] [PATCH] virtio-net: don't run bh on vm stopped Michael S. Tsirkin
2014-09-03 10:45 ` Stefan Hajnoczi [this message]
2014-09-03 11:27 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140903104557.GG28095@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=aliguori@amazon.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).