From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46159)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1XP84j-0008EV-DX
	for qemu-devel@nongnu.org; Wed, 03 Sep 2014 06:46:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1XP84e-0002a2-KJ
	for qemu-devel@nongnu.org; Wed, 03 Sep 2014 06:46:05 -0400
Date: Wed, 3 Sep 2014 11:45:57 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20140903104557.GG28095@stefanha-thinkpad.redhat.com>
References: <1409667966-16907-1-git-send-email-mst@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="4ndw/alBWmZEhfcZ"
Content-Disposition: inline
In-Reply-To: <1409667966-16907-1-git-send-email-mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] virtio-net: don't run bh on vm stopped
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Anthony Liguori <aliguori@amazon.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, qemu-stable@nongnu.org


--4ndw/alBWmZEhfcZ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Sep 02, 2014 at 05:26:12PM +0300, Michael S. Tsirkin wrote:
> commit 783e7706937fe15523b609b545587a028a2bdd03
>     virtio-net: stop/start bh when appropriate
>=20
> is incomplete: BH might execute within the same main loop iteration but
> after vmstop, so in theory, we might trigger an assertion.
> I was unable to reproduce this in practice,
> but it seems clear enough that the potential is there, so worth fixing.
>=20
> Cc: qemu-stable@nongnu.org
> Reported-by: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>  hw/net/virtio-net.c | 14 ++++++++++++--
>  1 file changed, 12 insertions(+), 2 deletions(-)

Thanks, applied to my net tree:
https://github.com/stefanha/qemu/commits/net

Stefan

--4ndw/alBWmZEhfcZ
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJUBvFlAAoJEJykq7OBq3PI3ZYH/R1i+0doXJzZkWL5zsL52VP9
88hv/PQjYisRkX1oQZkCihitG4Bvzl1pq7880GcI4C26UaMVoMwhA4KYnI9H0SeB
3ht4jTfzlqwcAQJbogdHwKpJGemS6okbEaiLhO8NdnB9VYf/Cup+0CkgiGTipVPB
Z4aOkYKRVylj11DAOr/A+RFitjLTAwPfIFIf7yE5QZK4xtuWPBle/E0ro8Je2AT1
10d57HVMbeY2ilET7qsekwJHGTNz7fqkI6qGHhK049VRLJ88uUMhY0xlWtEko4PL
DSB6BQUbGizvK0G9aEDZniC83OH+dWgE4kSClUg30sIvj74cFD+UNJ22tlaAMnQ=
=p4Mo
-----END PGP SIGNATURE-----

--4ndw/alBWmZEhfcZ--