From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54833)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XP8gD-0005Jb-Gt
	for qemu-devel@nongnu.org; Wed, 03 Sep 2014 07:24:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XP8g8-0006QL-CD
	for qemu-devel@nongnu.org; Wed, 03 Sep 2014 07:24:49 -0400
Date: Wed, 3 Sep 2014 14:27:57 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20140903112757.GB9982@redhat.com>
References: <1409667966-16907-1-git-send-email-mst@redhat.com>
	<20140903104557.GG28095@stefanha-thinkpad.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20140903104557.GG28095@stefanha-thinkpad.redhat.com>
Subject: Re: [Qemu-devel] [PATCH] virtio-net: don't run bh on vm stopped
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Anthony Liguori <aliguori@amazon.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, qemu-stable@nongnu.org

On Wed, Sep 03, 2014 at 11:45:57AM +0100, Stefan Hajnoczi wrote:
> On Tue, Sep 02, 2014 at 05:26:12PM +0300, Michael S. Tsirkin wrote:
> > commit 783e7706937fe15523b609b545587a028a2bdd03
> >     virtio-net: stop/start bh when appropriate
> > 
> > is incomplete: BH might execute within the same main loop iteration but
> > after vmstop, so in theory, we might trigger an assertion.
> > I was unable to reproduce this in practice,
> > but it seems clear enough that the potential is there, so worth fixing.
> > 
> > Cc: qemu-stable@nongnu.org
> > Reported-by: Stefan Hajnoczi <stefanha@redhat.com>
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> >  hw/net/virtio-net.c | 14 ++++++++++++--
> >  1 file changed, 12 insertions(+), 2 deletions(-)
> 
> Thanks, applied to my net tree:
> https://github.com/stefanha/qemu/commits/net
> 
> Stefan

It was actually on my tree already but since
I recalled my last pull request, no problem.
Can you send pull request with this today please,
so it can go into 2.1.1?