From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50815) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XP70x-0008Nz-VW for qemu-devel@nongnu.org; Wed, 03 Sep 2014 05:38:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XP70o-0001VU-UV for qemu-devel@nongnu.org; Wed, 03 Sep 2014 05:38:07 -0400 Received: from e06smtp17.uk.ibm.com ([195.75.94.113]:33480) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XP70o-0001D5-MK for qemu-devel@nongnu.org; Wed, 03 Sep 2014 05:37:58 -0400 Received: from /spool/local by e06smtp17.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 3 Sep 2014 10:37:35 +0100 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id AF6022190023 for ; Wed, 3 Sep 2014 10:37:13 +0100 (BST) Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id s839bWex36306982 for ; Wed, 3 Sep 2014 09:37:32 GMT Received: from d06av02.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s839bSJZ001235 for ; Wed, 3 Sep 2014 03:37:31 -0600 Date: Wed, 3 Sep 2014 11:37:24 +0200 From: David Hildenbrand Message-ID: <20140903113724.544f594b@thinkpad-w530> In-Reply-To: References: <1409320338-63098-1-git-send-email-jfrei@linux.vnet.ibm.com> <1409320338-63098-6-git-send-email-jfrei@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 5/5] gdb: provide the name of the architecture in the target.xml List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Alexander Graf , QEMU Developers , Christian Borntraeger , Jens Freimann , "Vassili Karpov (malc)" , Cornelia Huck , Andreas =?UTF-8?B?RsOkcmJlcg==?= > [ccing Andreas in case he wants to review the QOM aspects of this, > though they're fairly straightforward I think.] > > On 29 August 2014 14:52, Jens Freimann wrote: > > From: David Hildenbrand > > > > This patch provides the name of the architecture in the target.xml if available. > > > > This allows the remote gdb to detect the target architecture on its own - so > > there is no need to specify it manually (e.g. if gdb is started without a > > binary) using "set arch *arch_name*". > > This is neat; I didn't realise gdb let you do this. > > > The name of the architecture has been added to all archs that provide a > > target.xml (by supplying a gdb_core_xml_file) and have a unique architecture > > name in gdb's feature xml files. > > What about 32-bit ARM? You set the architecture name for AArch64 > but not the 32 bit case. > Well, my point was to not break anything :) On my way through the possible architecture names (binutils-gdb/gdb/features/*.xml), I wasn't able to come up with the right name for arm 32 bit (arm-core.xml) - they don't specify any. This patch therefore adapts to the xml files from gdb. The architecture should be known at the same point when specifying the xml file. So if anyone can come up with the proper arm name in the future (or even some kind of detection algorithm), it can simply be set in target-arm/cpu.c (after "arm-core.xml"). David