From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59345) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPCdv-0004G6-Kd for qemu-devel@nongnu.org; Wed, 03 Sep 2014 11:39:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XPCdH-0004s2-Dj for qemu-devel@nongnu.org; Wed, 03 Sep 2014 11:38:43 -0400 Received: from mail-we0-x233.google.com ([2a00:1450:400c:c03::233]:58307) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPCdH-0004rF-8I for qemu-devel@nongnu.org; Wed, 03 Sep 2014 11:38:03 -0400 Received: by mail-we0-f179.google.com with SMTP id t60so8715044wes.38 for ; Wed, 03 Sep 2014 08:38:00 -0700 (PDT) Date: Wed, 3 Sep 2014 16:37:57 +0100 From: Stefan Hajnoczi Message-ID: <20140903153757.GA30664@stefanha-thinkpad.redhat.com> References: <1406636839-11946-1-git-send-email-tumanova@linux.vnet.ibm.com> <1406636839-11946-3-git-send-email-tumanova@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="VbJkn9YxBvnuCH5J" Content-Disposition: inline In-Reply-To: <1406636839-11946-3-git-send-email-tumanova@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH 2/4] blocksize: support auto-sensing of blocksizes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ekaterina Tumanova Cc: cornelia.huck@de.ibm.com, dahi@linux.vnet.ibm.com, Public KVM Mailing List , borntraeger@de.ibm.com --VbJkn9YxBvnuCH5J Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 29, 2014 at 02:27:17PM +0200, Ekaterina Tumanova wrote: > The block device model does not impose fixed block sizes for > access to backing devices. This patch introduces support for > auto lookup of the block sizes of the backing block device. >=20 > To achieve this, a new function blkconf_blocksizes is > implemented. This function tries to get values > from the block driver. If this does not work 512 is used, > so the default excecution logic is not changed. >=20 > Based on 2013 patch from Einar Lueck >=20 > Signed-off-by: Ekaterina Tumanova > Reviewed-by: David Hildenbrand > Acked-by: Cornelia Huck > --- > block.c | 12 ++++++++++++ > hw/block/block.c | 25 +++++++++++++++++++++++++ > hw/core/qdev-properties.c | 4 +++- > include/block/block.h | 1 + > include/block/block_int.h | 5 +++++ > include/hw/block/block.h | 2 ++ > 6 files changed, 48 insertions(+), 1 deletion(-) This should be implemented as part of BlockLimits and bdrv_refresh_limits(). --VbJkn9YxBvnuCH5J Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUBzXVAAoJEJykq7OBq3PI83EH/2vobzhDZV9bLdV8ZBxZgmGK /NxUB/IjPCSkCTtHn1l00MjodUd6EwMrbqlE8YuQ6h58yz4wf6JUE95em2dGCsG+ B1S9KklWuqdCZZ7qDQz8gyOKqWutWW6sYfuF7PoQP5RqYSwaVF/JXr7uFTItM18J Y79jKCVNmUGggXJVA4WG90qX8qKEYjexuARK6Q60lfCzyuloz9Kwi5L4qopBt3uF INqROc5JhZaiuuUsRF5eDbubviPdnKzy0pgvyxOqRF2+7GGyG6pE5iehU5w1Ckhk 1kWy7eU0e/50/2z0O0rRe3vI5y5zE+/9bnFXuYJ32KoEh1T5S30HydWQjdU8WGo= =Fqo8 -----END PGP SIGNATURE----- --VbJkn9YxBvnuCH5J--