From: Stefan Hajnoczi <stefanha@gmail.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Jason Wang <jasowang@redhat.com>,
Anthony Liguori <aliguori@amazon.com>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/3] net: invoke callback when purging queue
Date: Thu, 4 Sep 2014 14:38:33 +0100 [thread overview]
Message-ID: <20140904133833.GB27130@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1409816839-12309-1-git-send-email-mst@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 740 bytes --]
On Thu, Sep 04, 2014 at 11:39:10AM +0300, Michael S. Tsirkin wrote:
> devices rely on packet callbacks eventually running,
> but we violate this rule whenever we purge the queue.
> To fix, invoke callbacks on all packets on purge.
> Set length to 0, this way callers can detect that
> this happened and re-queue if necessary.
>
> Cc: qemu-stable@nongnu.org
> Cc: Jason Wang <jasowang@redhat.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> net/queue.c | 3 +++
> 1 file changed, 3 insertions(+)
Merged "virtio: don't call device on !vm_running" before this to prevent
the assertion failures that Jason mentioned.
Thanks, applied to my net tree:
https://github.com/stefanha/qemu/commits/net
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2014-09-04 13:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-04 8:39 [Qemu-devel] [PATCH 1/3] net: invoke callback when purging queue Michael S. Tsirkin
2014-09-04 8:39 ` [Qemu-devel] [PATCH 2/3] net: complete all queued packets on VM stop Michael S. Tsirkin
2014-09-04 10:15 ` Jason Wang
2014-09-04 10:32 ` Michael S. Tsirkin
2014-09-04 8:39 ` [Qemu-devel] [PATCH 3/3] virtio-net: purge outstanding packets when starting vhost Michael S. Tsirkin
2014-09-04 9:58 ` [Qemu-devel] [PATCH 1/3] net: invoke callback when purging queue Jason Wang
2014-09-04 13:38 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140904133833.GB27130@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=aliguori@amazon.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).