From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40688)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1XPXFM-0008NU-A2
	for qemu-devel@nongnu.org; Thu, 04 Sep 2014 09:38:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1XPXFH-0004SM-HV
	for qemu-devel@nongnu.org; Thu, 04 Sep 2014 09:38:44 -0400
Date: Thu, 4 Sep 2014 14:38:33 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20140904133833.GB27130@stefanha-thinkpad.redhat.com>
References: <1409816839-12309-1-git-send-email-mst@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="R3G7APHDIzY6R/pk"
Content-Disposition: inline
In-Reply-To: <1409816839-12309-1-git-send-email-mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/3] net: invoke callback when purging queue
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Jason Wang <jasowang@redhat.com>, Anthony Liguori <aliguori@amazon.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, qemu-stable@nongnu.org


--R3G7APHDIzY6R/pk
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Sep 04, 2014 at 11:39:10AM +0300, Michael S. Tsirkin wrote:
> devices rely on packet callbacks eventually running,
> but we violate this rule whenever we purge the queue.
> To fix, invoke callbacks on all packets on purge.
> Set length to 0, this way callers can detect that
> this happened and re-queue if necessary.
>=20
> Cc: qemu-stable@nongnu.org
> Cc: Jason Wang <jasowang@redhat.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>  net/queue.c | 3 +++
>  1 file changed, 3 insertions(+)

Merged "virtio: don't call device on !vm_running" before this to prevent
the assertion failures that Jason mentioned.

Thanks, applied to my net tree:
https://github.com/stefanha/qemu/commits/net

Stefan

--R3G7APHDIzY6R/pk
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJUCGtZAAoJEJykq7OBq3PILrQIAMGtCFIrk6TMonyGnWJyCucK
LTTIjnIXMvJENY/WnQPtIBxSJ2JGyW19ecDCc+obmc87EDuJVf0DFhbqInxPQCZl
uI6Qq+/mMUHE+JEa7bgu64yGTQ7hJbZo6ivqje0Aa6FmY1HSFamuUvJNN18UGY96
djQQch/g42PIyk3/FchZADSGd0vLUTEiRlzKi4+1caR1I7jBqtv8EtpJ2n7OP8Li
30ow1pJYcKA4eytBYJMnk6DsBrqWnkrvEqz01pDq+8orO/lDnsQ9dZuaU21T8kiE
8Kj6NstW1/kSvasHehN2oo9o4pXxIXtDl8yE7yQvSQzYlj00odCnj3uytvV7lk8=
=NJJZ
-----END PGP SIGNATURE-----

--R3G7APHDIzY6R/pk--