From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57347) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPWPG-0004mf-FD for qemu-devel@nongnu.org; Thu, 04 Sep 2014 08:45:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XPWPB-0000gZ-QZ for qemu-devel@nongnu.org; Thu, 04 Sep 2014 08:44:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20830) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPWPB-0000fL-IW for qemu-devel@nongnu.org; Thu, 04 Sep 2014 08:44:49 -0400 Date: Thu, 4 Sep 2014 14:44:41 +0200 From: Igor Mammedov Message-ID: <20140904144441.6a88b757@nial.usersys.redhat.com> In-Reply-To: <1409126919-22233-4-git-send-email-tangchen@cn.fujitsu.com> References: <1409126919-22233-1-git-send-email-tangchen@cn.fujitsu.com> <1409126919-22233-4-git-send-email-tangchen@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RESEND PATCH v3 3/8] pc: Add memory hot unplug support for pc machine. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Tang Chen Cc: zhugh.fnst@cn.fujitsu.com, mst@redhat.com, hutao@cn.fujitsu.com, qemu-devel@nongnu.org, isimatu.yasuaki@jp.fujitsu.com, pbonzini@redhat.com On Wed, 27 Aug 2014 16:08:34 +0800 Tang Chen wrote: > From: Hu Tao > > Implement device unplug callback for PCMachine. And it now only support > pc-dimm hot-remove. The callback will call piix4 or ich9 callbacks introduced > in previous patches. > > Signed-off-by: Hu Tao > Signed-off-by: Tang Chen > --- > hw/i386/pc.c | 32 ++++++++++++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > > diff --git a/hw/i386/pc.c b/hw/i386/pc.c > index 8fa8d2f..8bafe7c 100644 > --- a/hw/i386/pc.c > +++ b/hw/i386/pc.c > @@ -61,6 +61,8 @@ > #include "hw/mem/pc-dimm.h" > #include "trace.h" > #include "qapi/visitor.h" > +#include "hw/acpi/piix4.h" > +#include "hw/i386/ich9.h" > > /* debug PC/ISA interrupts */ > //#define DEBUG_IRQ > @@ -1607,6 +1609,27 @@ out: > error_propagate(errp, local_err); > } > > +static void pc_dimm_unplug(HotplugHandler *hotplug_dev, > + DeviceState *dev, Error **errp) > +{ > + Object *acpi_dev; > + HotplugHandlerClass *hhc; > + Error *local_err = NULL; > + > + acpi_dev = (acpi_dev = piix4_pm_find()) ? acpi_dev : ich9_lpc_find(); > + if (!acpi_dev) { > + error_setg(&local_err, > + "memory hotplug is not enabled: missing acpi device"); > + error_propagate(errp, local_err); > + return; > + } drop/replace above block, see: "if (!pcms->acpi_dev) {" for reference > + > + hhc = HOTPLUG_HANDLER_GET_CLASS(acpi_dev); > + hhc->unplug(HOTPLUG_HANDLER(acpi_dev), dev, &local_err); you should take care about dev's vmstate here, that was registered in pc_dimm_plug() > + > + error_propagate(errp, local_err); > +} > + > static void pc_machine_device_plug_cb(HotplugHandler *hotplug_dev, > DeviceState *dev, Error **errp) > { > @@ -1615,6 +1638,14 @@ static void pc_machine_device_plug_cb(HotplugHandler *hotplug_dev, > } > } > > +static void pc_machine_device_unplug_cb(HotplugHandler *hotplug_dev, > + DeviceState *dev, Error **errp) > +{ > + if (object_dynamic_cast(OBJECT(dev), TYPE_PC_DIMM)) { > + pc_dimm_unplug(hotplug_dev, dev, errp); > + } > +} > + > static HotplugHandler *pc_get_hotpug_handler(MachineState *machine, > DeviceState *dev) > { > @@ -1701,6 +1732,7 @@ static void pc_machine_class_init(ObjectClass *oc, void *data) > pcmc->get_hotplug_handler = mc->get_hotplug_handler; > mc->get_hotplug_handler = pc_get_hotpug_handler; > hc->plug = pc_machine_device_plug_cb; > + hc->unplug = pc_machine_device_unplug_cb; > } > > static const TypeInfo pc_machine_info = {