From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38191) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPX5a-0005ls-1M for qemu-devel@nongnu.org; Thu, 04 Sep 2014 09:28:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XPX5V-0000gD-Eh for qemu-devel@nongnu.org; Thu, 04 Sep 2014 09:28:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59793) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPX5V-0000g4-5p for qemu-devel@nongnu.org; Thu, 04 Sep 2014 09:28:33 -0400 Date: Thu, 4 Sep 2014 15:28:24 +0200 From: Igor Mammedov Message-ID: <20140904152824.6ab1f113@nial.usersys.redhat.com> In-Reply-To: <1409126919-22233-6-git-send-email-tangchen@cn.fujitsu.com> References: <1409126919-22233-1-git-send-email-tangchen@cn.fujitsu.com> <1409126919-22233-6-git-send-email-tangchen@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RESEND PATCH v3 5/8] pc-dimm: Add pc_dimm_unrealize() for memory hot unplug support. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Tang Chen Cc: zhugh.fnst@cn.fujitsu.com, mst@redhat.com, hutao@cn.fujitsu.com, qemu-devel@nongnu.org, isimatu.yasuaki@jp.fujitsu.com, pbonzini@redhat.com On Wed, 27 Aug 2014 16:08:36 +0800 Tang Chen wrote: > From: Hu Tao > > Implement unrealize function for pc-dimm device. It delete subregion from s/delete/removes/ > hotplug region, and delete ram address range from guest ram list. > > Signed-off-by: Hu Tao > Signed-off-by: Tang Chen > --- > hw/mem/pc-dimm.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/hw/mem/pc-dimm.c b/hw/mem/pc-dimm.c > index 20fe0dc..34109a2 100644 > --- a/hw/mem/pc-dimm.c > +++ b/hw/mem/pc-dimm.c > @@ -270,12 +270,22 @@ static MemoryRegion *pc_dimm_get_memory_region(PCDIMMDevice *dimm) > return host_memory_backend_get_memory(dimm->hostmem, &error_abort); > } > > +static void pc_dimm_unrealize(DeviceState *dev, Error **errp) > +{ > + PCDIMMDevice *dimm = PC_DIMM(dev); > + MemoryRegion *mr = pc_dimm_get_memory_region(dimm); > + > + memory_region_del_subregion(mr->container, mr); usually MemoryRegion is treated as opaque and it's fields accessed via memory_region_foo() helpers. > + vmstate_unregister_ram(mr, dev); these 2 lines look like a job for PCMachine which did original mapping/vmstate registration > +} > + > static void pc_dimm_class_init(ObjectClass *oc, void *data) > { > DeviceClass *dc = DEVICE_CLASS(oc); > PCDIMMDeviceClass *ddc = PC_DIMM_CLASS(oc); > > dc->realize = pc_dimm_realize; > + dc->unrealize = pc_dimm_unrealize; > dc->props = pc_dimm_properties; > > ddc->get_memory_region = pc_dimm_get_memory_region;