From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49162) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPZRn-0001Uf-Hi for qemu-devel@nongnu.org; Thu, 04 Sep 2014 11:59:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XPZRi-0000yk-K0 for qemu-devel@nongnu.org; Thu, 04 Sep 2014 11:59:43 -0400 Date: Thu, 4 Sep 2014 19:02:35 +0300 From: "Michael S. Tsirkin" Message-ID: <20140904160235.GF21203@redhat.com> References: <1409797106-9076-1-git-send-email-arei.gonglei@huawei.com> <20140904153037.GA21203@redhat.com> <540889C9.3060808@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <540889C9.3060808@suse.de> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v6 0/3] Refactor device_set_realized to avoid resource leak List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: peter.crosthwaite@xilinx.com, weidong.huang@huawei.com, luonengjun@huawei.com, qemu-stable@nongnu.org, qemu-devel@nongnu.org, arei.gonglei@huawei.com, imammedo@redhat.com, pbonzini@redhat.com, peter.huangpeng@huawei.com On Thu, Sep 04, 2014 at 05:48:25PM +0200, Andreas F=E4rber wrote: > Am 04.09.2014 17:30, schrieb Michael S. Tsirkin: > > On Thu, Sep 04, 2014 at 10:18:23AM +0800, arei.gonglei@huawei.com wro= te: > >> From: Gonglei > >> > >> after committing > >> [PATCH v6 0/9] Refactor PCI/SHPC/PCIE hotplug to use a more generic= hotplug API > >> > >> If devcie hotplugging failed, will casuse resource leak. > >> This patch series include address resouce leak and two other issuses. > >> > >> v6 -> v5: > >> - rework patch 2/3 by Peter's suggestion. > >> - add 'Reviewed-by' tag. > >> - remove a patch about PCIe hotplugging by Michael's idea. > >> > >> v5 -> v4: > >> - add patch 1/4 'Reviewed-by' tag. > >> - change patch 2/4, propagate firsh child unrealizing failure, and > >> change this patch's commit message.(Peter) > >> > >> v4 -> v3: > >> - add patch 2/4.(Thanks for Peter's suggestion) > >> - rework patch 3/4 based on patch 2/4. > >> > >> v3 -> v2: > >> - add cleanup logic for set bus/child_bus realized/unrealized faile= d. > >> - change patch 1/3 commit message, add 'Reviewed-by' tag. > >> > >> v2 -> v1: > >> - rewrite patch 1/3, using error_abort instead of local_err. > >> - rewrite patch 2/3, add cleanup logic for different error embranch= ment. > >> - rewrite title of patch 3/3, and a syntax fix. > >> > >> Gonglei (3): > >> qdev: using error_abort instead of using local_err > >> qdev: using NULL instead of local_err for qbus_child unrealize > >> qdev: add cleanup logic in device_set_realized() to avoid resource > >> leak > >=20 > > Applied and Cc qemu-stable, thanks! >=20 > Objection, patch 1/3 is already on qom-next. Please make sure to sync > the commit message if you want to take it through your tree. >=20 > Thanks, > Andreas No, it's ok, I'll drop it - but please remember to notify list when you pick up patches (if you did and I missed this somehow, my apologies). Also pls remember to add Cc qemu-stable in your tree. Other QOM related patches: hw/machine: Free old values of string properties and virtio-pci: fix virtio-net child refcount in transports would you like to pick them up as well? > >=20 > >> hw/core/qdev.c | 70 +++++++++++++++++++++++++++++++++++++++--------= ----------- > >> 1 file changed, 47 insertions(+), 23 deletions(-) > >> > >> --=20 > >> 1.7.12.4 > >> > >> >=20 >=20 > --=20 > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrn= berg