From: Stefan Hajnoczi <stefanha@gmail.com>
To: Fam Zheng <famz@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
peter.maydell@linaro.org
Subject: Re: [Qemu-devel] [PATCH 1/3] trace: Only link generated-tracers.o with "simple" backend
Date: Fri, 5 Sep 2014 10:04:30 +0100 [thread overview]
Message-ID: <20140905090430.GA18562@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1409715896-14322-2-git-send-email-famz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 555 bytes --]
On Wed, Sep 03, 2014 at 11:44:54AM +0800, Fam Zheng wrote:
> In any other cases the object file is effectively empty, which is
> disliked by ranlib and nm on Mac OS X.
>
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> trace/Makefile.objs | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
If another trace backend uses generate_c() there will be a link error so
they'll figure out they need to add it in the makefile.
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-09-05 9:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-03 3:44 [Qemu-devel] [PATCH 0/3] build-sys: Exclude empty object files when linking libqemuutil.a Fam Zheng
2014-09-03 3:44 ` [Qemu-devel] [PATCH 1/3] trace: Only link generated-tracers.o with "simple" backend Fam Zheng
2014-09-05 9:04 ` Stefan Hajnoczi [this message]
2014-09-03 3:44 ` [Qemu-devel] [PATCH 2/3] util: Move general qemu_getauxval to util/getauxval.c Fam Zheng
2014-09-03 3:44 ` [Qemu-devel] [PATCH 3/3] util: Don't link host-utils.o if it's empty Fam Zheng
2014-09-03 7:53 ` [Qemu-devel] [PATCH 0/3] build-sys: Exclude empty object files when linking libqemuutil.a Paolo Bonzini
2014-09-10 6:19 ` Fam Zheng
2014-09-10 8:23 ` Paolo Bonzini
2014-09-03 11:49 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140905090430.GA18562@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=famz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).