From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49539) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPpRf-0001ba-5i for qemu-devel@nongnu.org; Fri, 05 Sep 2014 05:04:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XPpRZ-00057M-Ni for qemu-devel@nongnu.org; Fri, 05 Sep 2014 05:04:39 -0400 Received: from mail-we0-x22e.google.com ([2a00:1450:400c:c03::22e]:41776) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPpRZ-000573-Gz for qemu-devel@nongnu.org; Fri, 05 Sep 2014 05:04:33 -0400 Received: by mail-we0-f174.google.com with SMTP id u57so11568100wes.33 for ; Fri, 05 Sep 2014 02:04:32 -0700 (PDT) Date: Fri, 5 Sep 2014 10:04:30 +0100 From: Stefan Hajnoczi Message-ID: <20140905090430.GA18562@stefanha-thinkpad.redhat.com> References: <1409715896-14322-1-git-send-email-famz@redhat.com> <1409715896-14322-2-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="huq684BweRXVnRxX" Content-Disposition: inline In-Reply-To: <1409715896-14322-2-git-send-email-famz@redhat.com> Subject: Re: [Qemu-devel] [PATCH 1/3] trace: Only link generated-tracers.o with "simple" backend List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: Paolo Bonzini , qemu-devel@nongnu.org, Stefan Hajnoczi , peter.maydell@linaro.org --huq684BweRXVnRxX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 03, 2014 at 11:44:54AM +0800, Fam Zheng wrote: > In any other cases the object file is effectively empty, which is > disliked by ranlib and nm on Mac OS X. >=20 > Reported-by: Peter Maydell > Signed-off-by: Fam Zheng > --- > trace/Makefile.objs | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) If another trace backend uses generate_c() there will be a link error so they'll figure out they need to add it in the makefile. Reviewed-by: Stefan Hajnoczi --huq684BweRXVnRxX Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUCXyeAAoJEJykq7OBq3PIOIUH/0NYR+VTI8vtPCbCvGvDYJwI h1MgsMC4EnfiWRkJrXsQ6H52D0edVD9IA+HeZugL9/RcPK7UyvWIekDxAShXwZyR jmkFXmj8lpibozmWCpT6nnSPC5aXKBTTUtdFGaUKsXyV1aCYALoAaokiM3qAh00G xFpELFeMQRarOros5ElciIhAzoDQqPyne3eZaqh+i8xjcYlxOZL9viIBpH9FC0nf Ukr5vpJsSR9S3zGCeVmxNmnDc2tQP1QH7hhD/fcWgprcs8l7G5L5d/afO4JwKVQf Yga9FM/xtF2Ee2nBs1OKR33hxK5dDoOc+Ke2vExbOAYhQwpGc7xqxn64q1cVSQY= =3NMl -----END PGP SIGNATURE----- --huq684BweRXVnRxX--