From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33474) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPqe9-0006lS-2k for qemu-devel@nongnu.org; Fri, 05 Sep 2014 06:21:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XPqdz-000883-LF for qemu-devel@nongnu.org; Fri, 05 Sep 2014 06:21:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37597) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPqdz-00087z-EE for qemu-devel@nongnu.org; Fri, 05 Sep 2014 06:21:27 -0400 Date: Fri, 5 Sep 2014 12:21:23 +0200 From: Kevin Wolf Message-ID: <20140905102123.GE4656@noname.str.redhat.com> References: <1409568798-2292-1-git-send-email-junmuzi@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1409568798-2292-1-git-send-email-junmuzi@gmail.com> Subject: Re: [Qemu-devel] [PATCH v2] qcow2: add update refcount table realization for update_refcount List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jun Li Cc: famz@redhat.com, juli@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com Am 01.09.2014 um 12:52 hat Jun Li geschrieben: > When every item of refcount block is NULL, free refcount block and reset the > corresponding item of refcount table with NULL. > > Signed-off-by: Jun Li The commit message should also describe why this is a relevant improvement for some use case. My gut feeling is that it complicates the code for a very minimal gain. Kevin