qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: Jun Li <junmuzi@gmail.com>
Cc: kwolf@redhat.com, juli@redhat.com, famz@redhat.com,
	qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2] qcow2: add update refcount table realization for update_refcount
Date: Fri, 5 Sep 2014 16:34:56 +0100	[thread overview]
Message-ID: <20140905153456.GI27649@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1409568798-2292-1-git-send-email-junmuzi@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 392 bytes --]

On Mon, Sep 01, 2014 at 06:52:48PM +0800, Jun Li wrote:
> When every item of refcount block is NULL, free refcount block and reset the
> corresponding item of refcount table with NULL.
> 
> Signed-off-by: Jun Li <address@hidden>
> ---

By the way, test cases are definitely needed for this change.  See
tests/qemu-iotests/qcow2.py and the test cases in tests/qemu-iotests.

Stefan

[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]

      parent reply	other threads:[~2014-09-05 15:35 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-01 10:52 [Qemu-devel] [PATCH v2] qcow2: add update refcount table realization for update_refcount Jun Li
2014-09-01 11:11 ` Benoît Canet
2014-09-01 16:04   ` Jun Li
2014-09-02 13:38     ` Benoît Canet
2014-09-02 17:12 ` Greg Kurz
2014-09-22  1:45   ` jun muzi
2014-09-05 10:21 ` Kevin Wolf
2014-09-09  2:52   ` Jun Li
2014-09-09  8:21     ` Kevin Wolf
2014-09-09 14:04       ` Jun Li
2014-09-05 15:33 ` Stefan Hajnoczi
2014-09-13 15:53   ` Jun Li
2014-09-15  9:27     ` Stefan Hajnoczi
2014-09-05 15:34 ` Stefan Hajnoczi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140905153456.GI27649@stefanha-thinkpad.redhat.com \
    --to=stefanha@gmail.com \
    --cc=famz@redhat.com \
    --cc=juli@redhat.com \
    --cc=junmuzi@gmail.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).