From: Stefan Hajnoczi <stefanha@gmail.com>
To: "Richard W.M. Jones" <rjones@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] qcow2, lazy_refcounts and killing qemu
Date: Fri, 5 Sep 2014 16:39:51 +0100 [thread overview]
Message-ID: <20140905153951.GJ27649@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <20140830145313.GN14001@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1056 bytes --]
On Sat, Aug 30, 2014 at 03:53:13PM +0100, Richard W.M. Jones wrote:
> I found out a few days ago that if you:
>
> (1) Open a qcow2 file that has lazy_refcounts = on and a backing file, and
>
> (2) Write lots of stuff, and
>
> (3) Kill qemu with SIGTERM [which I believed, maybe incorrectly, is a
> "nice" way to kill qemu]
>
> .. then you can end up with a corrupt qcow2 file. In particular the
> qcow2 file sometimes forgot that it had a backing file, but I suspect
> this was just a symptom and in fact the qcow2 file header wasn't being
> written to disk correctly.
>
> Is it correct that sending SIGTERM to qemu should kill it cleanly, or
> is that no longer the case, or is lazy_refcounts a special case, or
> have I found a bug?
>
> I can reproduce this easily, although of course the reproducer will
> involve libguestfs.
That is very interesting, thanks for posting.
Did you try older QEMU versions? I'm curious if this is something that
crept in later or is fundamentally broken in lazy_refcounts=on.
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-09-05 15:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-30 14:53 [Qemu-devel] qcow2, lazy_refcounts and killing qemu Richard W.M. Jones
2014-09-01 12:41 ` Greg Kurz
2014-09-01 13:07 ` Richard W.M. Jones
2014-09-01 14:19 ` Richard W.M. Jones
2014-09-01 14:23 ` Richard W.M. Jones
2014-09-01 14:30 ` Greg Kurz
2014-09-05 15:39 ` Stefan Hajnoczi [this message]
2014-09-05 17:41 ` Richard W.M. Jones
2014-09-08 7:16 ` Markus Armbruster
2014-09-08 18:29 ` Max Reitz
2014-09-08 9:57 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140905153951.GJ27649@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).