From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48458) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XQv1v-0000cm-FZ for qemu-devel@nongnu.org; Mon, 08 Sep 2014 05:14:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XQv1o-0003n8-U3 for qemu-devel@nongnu.org; Mon, 08 Sep 2014 05:14:35 -0400 Received: from mail-we0-x229.google.com ([2a00:1450:400c:c03::229]:43434) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XQv1o-0003ll-NZ for qemu-devel@nongnu.org; Mon, 08 Sep 2014 05:14:28 -0400 Received: by mail-we0-f169.google.com with SMTP id w61so358482wes.0 for ; Mon, 08 Sep 2014 02:14:27 -0700 (PDT) Date: Mon, 8 Sep 2014 10:14:25 +0100 From: Stefan Hajnoczi Message-ID: <20140908091425.GG7638@stefanha-thinkpad.redhat.com> References: <4044e6699f48e9248cabe4fca4137d077cb37868.1409216371.git.hutao@cn.fujitsu.com> <20140829160620.GE20193@stefanha-thinkpad.redhat.com> <20140904090301.GA541@G08FNSTD100614.fnst.cn.fujitsu.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="PyMzGVE0NRonI6bs" Content-Disposition: inline In-Reply-To: <20140904090301.GA541@G08FNSTD100614.fnst.cn.fujitsu.com> Subject: Re: [Qemu-devel] [PATCH 1/2] qemu-iotests: fix filter of encryption option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hu Tao Cc: Kevin Wolf , qemu-devel@nongnu.org --PyMzGVE0NRonI6bs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 04, 2014 at 05:03:01PM +0800, Hu Tao wrote: > On Fri, Aug 29, 2014 at 05:06:20PM +0100, Stefan Hajnoczi wrote: > > On Thu, Aug 28, 2014 at 04:56:03PM +0800, Hu Tao wrote: > > > We should filter out encryption=3Don, too. > > >=20 > > > Signed-off-by: Hu Tao > > > --- > > > tests/qemu-iotests/common.filter | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > >=20 > > > diff --git a/tests/qemu-iotests/common.filter b/tests/qemu-iotests/co= mmon.filter > > > index 51192c8..362394e 100644 > > > --- a/tests/qemu-iotests/common.filter > > > +++ b/tests/qemu-iotests/common.filter > > > @@ -176,7 +176,7 @@ _filter_img_create() > > > sed -e "s#$IMGPROTO:$TEST_DIR#TEST_DIR#g" \ > > > -e "s#$TEST_DIR#TEST_DIR#g" \ > > > -e "s#$IMGFMT#IMGFMT#g" \ > > > - -e "s# encryption=3Doff##g" \ > > > + -e "s# encryption=3D\\(on\\|off\\)##g" \ > >=20 > > Why? >=20 > This is considered a bug of _filter_img_create(). It should have filtered= out > driver specific option 'encryption=3Don', too. You have not posted justification for this patch series. As far as I know, there is no reason to filter these options. And your series breaks qemu-iotests because you didn't update the .out files. NACK Stefan --PyMzGVE0NRonI6bs Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUDXNxAAoJEJykq7OBq3PIa0QIAIr7+aIF+NV9Ka/xbp7IuWVw /eZ75g8eE+Tnjct9sWP/5m3bfWRTX9MPbSEW3rhg1SMU+qs0IzDooDefSnSrcygn DnAfnfesTLyHo9oXT6FBNoMRKe2verJszos8KPbHZrqLxmMXcwa7SpsJRN1iz+Cy W+GiIwqCwyRQRNr+d2FJjNt6BRI52kBtMA4D2BTpdielN5x/96hUqLn/JaetG9o3 mDXratza5pKuNvMgAsGrBF7DPJ09cjeCium9YI12qFzBomZK0Xn5L2kvFvX0Y/e5 PPA26b6e3aGlrbeitH1FuehlBSsR3Fh6RcJ8bhcLyLMNYJiCOdrvSJLXPkfQcu4= =z3sc -----END PGP SIGNATURE----- --PyMzGVE0NRonI6bs--