From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40501) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XQz0J-0000Y4-HV for qemu-devel@nongnu.org; Mon, 08 Sep 2014 09:29:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XQz0E-0003Uy-Sk for qemu-devel@nongnu.org; Mon, 08 Sep 2014 09:29:11 -0400 Date: Mon, 8 Sep 2014 16:32:16 +0300 From: "Michael S. Tsirkin" Message-ID: <20140908133216.GA2168@redhat.com> References: <1408032488-11096-1-git-send-email-mst@redhat.com> <1408032488-11096-2-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1408032488-11096-2-git-send-email-mst@redhat.com> Subject: Re: [Qemu-devel] [PULL 01/12] pci: Use bus master address space for delivering MSI/MSI-X messages List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell , qemu-stable@nongnu.org, Anthony Liguori , Jan Kiszka On Thu, Aug 14, 2014 at 06:08:44PM +0200, Michael S. Tsirkin wrote: > From: Jan Kiszka > > The spec says (and real HW confirms this) that, if the bus master bit > is 0, the device will not generate any PCI accesses. MSI and MSI-X > messages fall among these, so we should use the corresponding address > space to deliver them. This will prevent delivery if bus master support > is disabled. > > Cc: qemu-stable@nongnu.org This is reported to break old guests which incorrectly don't enable bus mastering. Worth fixing (virtio needs a work-around) but please drop the patch from qemu-stable. Thanks! > Signed-off-by: Jan Kiszka > Reviewed-by: Michael S. Tsirkin > Signed-off-by: Michael S. Tsirkin > --- > hw/pci/msi.c | 2 +- > hw/pci/msix.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/pci/msi.c b/hw/pci/msi.c > index a4a3040..52d2313 100644 > --- a/hw/pci/msi.c > +++ b/hw/pci/msi.c > @@ -291,7 +291,7 @@ void msi_notify(PCIDevice *dev, unsigned int vector) > "notify vector 0x%x" > " address: 0x%"PRIx64" data: 0x%"PRIx32"\n", > vector, msg.address, msg.data); > - stl_le_phys(&address_space_memory, msg.address, msg.data); > + stl_le_phys(&dev->bus_master_as, msg.address, msg.data); > } > > /* Normally called by pci_default_write_config(). */ > diff --git a/hw/pci/msix.c b/hw/pci/msix.c > index 5c49bfc..20ae476 100644 > --- a/hw/pci/msix.c > +++ b/hw/pci/msix.c > @@ -439,7 +439,7 @@ void msix_notify(PCIDevice *dev, unsigned vector) > > msg = msix_get_message(dev, vector); > > - stl_le_phys(&address_space_memory, msg.address, msg.data); > + stl_le_phys(&dev->bus_master_as, msg.address, msg.data); > } > > void msix_reset(PCIDevice *dev) > -- > MST >