From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36128) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XRHGY-0006fz-Le for qemu-devel@nongnu.org; Tue, 09 Sep 2014 04:59:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XRHGS-0002dD-Gt for qemu-devel@nongnu.org; Tue, 09 Sep 2014 04:59:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55325) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XRHGS-0002d5-92 for qemu-devel@nongnu.org; Tue, 09 Sep 2014 04:59:04 -0400 Date: Tue, 9 Sep 2014 10:58:58 +0200 From: Kevin Wolf Message-ID: <20140909085858.GF4847@noname.str.redhat.com> References: <53F704BE.6000407@mrs.ro> <5402DD88.5010600@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5402DD88.5010600@gmail.com> Subject: Re: [Qemu-devel] [PATCH] IDE: MMIO IDE device control should be little endian List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Valentin Manea Cc: mjt@tls.msk.ru, "qemu-devel@nongnu.org" , stefanha@redhat.com Am 31.08.2014 um 10:32 hat Valentin Manea geschrieben: > > Set the IDE MMIO memory type to little endian. The ATA specs identify > words part of the control commands encoded as little endian. > While this has no impact on little endian systems, it's required for big > endian systems(eg OpenRisc). > > Signed-off-by: Valentin Manea Thanks, applied to the block branch. > static uint64_t mmio_ide_status_read(void *opaque, hwaddr addr, > @@ -102,7 +102,7 @@ static void mmio_ide_cmd_write(void *opaque, hwaddr > addr, Please make sure that your patch isn't corrupted by your mail client, like by this line wrap. I had to manually fix the patch before I could apply it. For larger patches, I would simply have rejected it. Kevin