From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46457) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XRi1j-0001Nz-6k for qemu-devel@nongnu.org; Wed, 10 Sep 2014 09:33:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XRi1d-0005yZ-31 for qemu-devel@nongnu.org; Wed, 10 Sep 2014 09:33:39 -0400 Received: from lputeaux-656-01-25-125.w80-12.abo.wanadoo.fr ([80.12.84.125]:42619 helo=paradis.irqsave.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XRi1c-0005yI-Os for qemu-devel@nongnu.org; Wed, 10 Sep 2014 09:33:33 -0400 Date: Wed, 10 Sep 2014 15:32:38 +0200 From: =?iso-8859-1?Q?Beno=EEt?= Canet Message-ID: <20140910133238.GD12470@irqsave.net> References: <1410318528-24433-1-git-send-email-famz@redhat.com> <1410318528-24433-4-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1410318528-24433-4-git-send-email-famz@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v6 3/3] qapi: Sort items in BlockdevOptions definition List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: Kevin Wolf , benoit.canet@irqsave.net, qemu-devel@nongnu.org, armbru@redhat.com, Stefan Hajnoczi , pbonzini@redhat.com The Wednesday 10 Sep 2014 =E0 11:08:48 (+0800), Fam Zheng wrote : > Signed-off-by: Fam Zheng > --- > qapi/block-core.json | 38 +++++++++++++++++++------------------- > 1 file changed, 19 insertions(+), 19 deletions(-) >=20 > diff --git a/qapi/block-core.json b/qapi/block-core.json > index 35191b4..5adef27 100644 > --- a/qapi/block-core.json > +++ b/qapi/block-core.json > @@ -1483,41 +1483,41 @@ > 'discriminator': 'driver', > 'data': { > 'archipelago':'BlockdevOptionsArchipelago', > + 'blkdebug': 'BlockdevOptionsBlkdebug', > + 'blkverify': 'BlockdevOptionsBlkverify', > + 'bochs': 'BlockdevOptionsGenericFormat', > + 'cloop': 'BlockdevOptionsGenericFormat', > + 'cow': 'BlockdevOptionsGenericCOWFormat', > + 'dmg': 'BlockdevOptionsGenericFormat', > 'file': 'BlockdevOptionsFile', > - 'host_device':'BlockdevOptionsFile', > + 'ftp': 'BlockdevOptionsFile', > + 'ftps': 'BlockdevOptionsFile', > +# TODO gluster: Wait for structured options > 'host_cdrom': 'BlockdevOptionsFile', > + 'host_device':'BlockdevOptionsFile', > 'host_floppy':'BlockdevOptionsFile', > 'http': 'BlockdevOptionsFile', > 'https': 'BlockdevOptionsFile', > - 'ftp': 'BlockdevOptionsFile', > - 'ftps': 'BlockdevOptionsFile', > - 'tftp': 'BlockdevOptionsFile', > -# TODO gluster: Wait for structured options > # TODO iscsi: Wait for structured options > # TODO nbd: Should take InetSocketAddress for 'host'? > # TODO nfs: Wait for structured options Do we want to move all the TODO sorted alphabetically at the same place ? Or do be want to put the TODOS sorted alphabetically near their respectiv= e option declaration ? > -# TODO rbd: Wait for structured options > -# TODO sheepdog: Wait for structured options > -# TODO ssh: Should take InetSocketAddress for 'host'? > - 'vvfat': 'BlockdevOptionsVVFAT', > - 'blkdebug': 'BlockdevOptionsBlkdebug', > - 'blkverify': 'BlockdevOptionsBlkverify', > - 'bochs': 'BlockdevOptionsGenericFormat', > - 'cloop': 'BlockdevOptionsGenericFormat', > - 'cow': 'BlockdevOptionsGenericCOWFormat', > - 'dmg': 'BlockdevOptionsGenericFormat', > + 'null-aio': 'BlockdevOptionsNull', > + 'null-co': 'BlockdevOptionsNull', > 'parallels': 'BlockdevOptionsGenericFormat', > - 'qcow': 'BlockdevOptionsGenericCOWFormat', > 'qcow2': 'BlockdevOptionsQcow2', > + 'qcow': 'BlockdevOptionsGenericCOWFormat', > 'qed': 'BlockdevOptionsGenericCOWFormat', > + 'quorum': 'BlockdevOptionsQuorum', > 'raw': 'BlockdevOptionsGenericFormat', > +# TODO rbd: Wait for structured options > +# TODO sheepdog: Wait for structured options > +# TODO ssh: Should take InetSocketAddress for 'host'? > + 'tftp': 'BlockdevOptionsFile', > 'vdi': 'BlockdevOptionsGenericFormat', > 'vhdx': 'BlockdevOptionsGenericFormat', > 'vmdk': 'BlockdevOptionsGenericCOWFormat', > 'vpc': 'BlockdevOptionsGenericFormat', > - 'quorum': 'BlockdevOptionsQuorum', > - 'null-aio': 'BlockdevOptionsNull', > - 'null-co': 'BlockdevOptionsNull' > + 'vvfat': 'BlockdevOptionsVVFAT' > } } > =20 > ## > --=20 > 1.9.3 >=20 >=20