From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44776) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XRhwb-0003sq-Fn for qemu-devel@nongnu.org; Wed, 10 Sep 2014 09:28:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XRhwU-0003km-R3 for qemu-devel@nongnu.org; Wed, 10 Sep 2014 09:28:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57086) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XRhwU-0003iK-JR for qemu-devel@nongnu.org; Wed, 10 Sep 2014 09:28:14 -0400 Date: Wed, 10 Sep 2014 15:28:01 +0200 From: Igor Mammedov Message-ID: <20140910152801.01f636d6@nial.usersys.redhat.com> In-Reply-To: <1409735177-17232-2-git-send-email-guz.fnst@cn.fujitsu.com> References: <1409735177-17232-1-git-send-email-guz.fnst@cn.fujitsu.com> <1409735177-17232-2-git-send-email-guz.fnst@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/5] acpi/cpu: add cpu hotplug callback function to match hotplug_handler API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gu Zheng Cc: chen.fan.fnst@cn.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, qemu-devel@nongnu.org, afaerber@suse.de, tangchen@cn.fujitsu.com On Wed, 3 Sep 2014 17:06:13 +0800 Gu Zheng wrote: > > Signed-off-by: Gu Zheng > --- > hw/acpi/cpu_hotplug.c | 17 +++++++++++++++++ > include/hw/acpi/cpu_hotplug.h | 3 +++ > 2 files changed, 20 insertions(+), 0 deletions(-) > > diff --git a/hw/acpi/cpu_hotplug.c b/hw/acpi/cpu_hotplug.c > index 2ad83a0..92c189b 100644 > --- a/hw/acpi/cpu_hotplug.c > +++ b/hw/acpi/cpu_hotplug.c > @@ -36,6 +36,23 @@ static const MemoryRegionOps AcpiCpuHotplug_ops = { > }, > }; > > +void acpi_cpu_plug_cb(ACPIREGS *ar, qemu_irq irq, > + AcpiCpuHotplug *g, DeviceState *dev) wrong indentation ^^^ it wouldn't hurt to add errp argument here ... > +{ > + CPUState *cpu = CPU(dev); > + CPUClass *k = CPU_GET_CLASS(cpu); > + int64_t cpu_id; > + > + ar->gpe.sts[0] |= ACPI_CPU_HOTPLUG_STATUS; > + cpu_id = k->get_arch_id(cpu); > + g_assert((cpu_id / 8) < ACPI_GPE_PROC_LEN); ... and return error from here instead of aborting > + g->sts[cpu_id / 8] |= (1 << (cpu_id % 8)); > + > + acpi_update_sci(ar, irq); > + > + cpu_resume(cpu); Why are you adding cpu_resume() here? check cpu_common_realizefn() which already does it. > +} > + > void AcpiCpuHotplug_add(ACPIGPE *gpe, AcpiCpuHotplug *g, CPUState *cpu) > { > CPUClass *k = CPU_GET_CLASS(cpu); > diff --git a/include/hw/acpi/cpu_hotplug.h b/include/hw/acpi/cpu_hotplug.h > index 9e5d30c..d025731 100644 > --- a/include/hw/acpi/cpu_hotplug.h > +++ b/include/hw/acpi/cpu_hotplug.h > @@ -20,6 +20,9 @@ typedef struct AcpiCpuHotplug { > uint8_t sts[ACPI_GPE_PROC_LEN]; > } AcpiCpuHotplug; > > +void acpi_cpu_plug_cb(ACPIREGS *ar, qemu_irq irq, > + AcpiCpuHotplug *g, DeviceState *dev); wrong indentation ^^^ > + > void AcpiCpuHotplug_add(ACPIGPE *gpe, AcpiCpuHotplug *g, CPUState *cpu); > > void AcpiCpuHotplug_init(MemoryRegion *parent, Object *owner,