From: Igor Mammedov <imammedo@redhat.com>
To: Gu Zheng <guz.fnst@cn.fujitsu.com>
Cc: chen.fan.fnst@cn.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com,
qemu-devel@nongnu.org, afaerber@suse.de, tangchen@cn.fujitsu.com
Subject: Re: [Qemu-devel] [PATCH 4/5] pc: add cpu hotplug handler to PC_MACHINE
Date: Wed, 10 Sep 2014 16:02:06 +0200 [thread overview]
Message-ID: <20140910160206.57a5ed8b@nial.usersys.redhat.com> (raw)
In-Reply-To: <1409735177-17232-5-git-send-email-guz.fnst@cn.fujitsu.com>
On Wed, 3 Sep 2014 17:06:16 +0800
Gu Zheng <guz.fnst@cn.fujitsu.com> wrote:
> diff --git a/qom/cpu.c b/qom/cpu.c
> index b32dd0a..af8e83f 100644
> --- a/qom/cpu.c
> +++ b/qom/cpu.c
> @@ -304,7 +304,6 @@ static void cpu_common_realizefn(DeviceState *dev, Error **errp)
> if (dev->hotplugged) {
> cpu_synchronize_post_init(cpu);
> notifier_list_notify(&cpu_added_notifiers, dev);
^^^ should be dropped as well an hotplug handler should take care about everything this call did.
> - cpu_resume(cpu);
> }
> }
>
next prev parent reply other threads:[~2014-09-10 14:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-03 9:06 [Qemu-devel] [PATCH 0/5] cpu/acpi: convert cpu hot plug to hotplug_handler API Gu Zheng
2014-09-03 9:06 ` [Qemu-devel] [PATCH 1/5] acpi/cpu: add cpu hotplug callback function to match " Gu Zheng
2014-09-10 13:28 ` Igor Mammedov
2014-09-11 3:04 ` Gu Zheng
2014-09-11 10:12 ` Igor Mammedov
2014-09-12 1:39 ` Gu Zheng
2014-09-03 9:06 ` [Qemu-devel] [PATCH 2/5] acpi:ich9: convert cpu hotplug handle to " Gu Zheng
2014-09-03 9:06 ` [Qemu-devel] [PATCH 3/5] acpi:piix4: " Gu Zheng
2014-09-03 9:06 ` [Qemu-devel] [PATCH 4/5] pc: add cpu hotplug handler to PC_MACHINE Gu Zheng
2014-09-10 13:55 ` Igor Mammedov
2014-09-12 3:02 ` Gu Zheng
2014-09-12 14:28 ` Igor Mammedov
2014-09-15 3:57 ` Gu Zheng
2014-09-15 8:11 ` Igor Mammedov
2014-09-10 14:02 ` Igor Mammedov [this message]
2014-09-03 9:06 ` [Qemu-devel] [PATCH 5/5] cpu/hotplug: remove the left unused cpu hotplug notifier function Gu Zheng
2014-09-10 13:59 ` Igor Mammedov
2014-09-10 14:12 ` [Qemu-devel] [PATCH 0/5] cpu/acpi: convert cpu hot plug to hotplug_handler API Igor Mammedov
2014-09-11 2:53 ` Gu Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140910160206.57a5ed8b@nial.usersys.redhat.com \
--to=imammedo@redhat.com \
--cc=afaerber@suse.de \
--cc=chen.fan.fnst@cn.fujitsu.com \
--cc=guz.fnst@cn.fujitsu.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=qemu-devel@nongnu.org \
--cc=tangchen@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).