From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52953)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1XRiTa-0005I2-G0
	for qemu-devel@nongnu.org; Wed, 10 Sep 2014 10:02:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1XRiTR-0006wP-Ht
	for qemu-devel@nongnu.org; Wed, 10 Sep 2014 10:02:22 -0400
Received: from mx1.redhat.com ([209.132.183.28]:29865)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1XRiTR-0006wK-9t
	for qemu-devel@nongnu.org; Wed, 10 Sep 2014 10:02:17 -0400
Date: Wed, 10 Sep 2014 16:02:06 +0200
From: Igor Mammedov <imammedo@redhat.com>
Message-ID: <20140910160206.57a5ed8b@nial.usersys.redhat.com>
In-Reply-To: <1409735177-17232-5-git-send-email-guz.fnst@cn.fujitsu.com>
References: <1409735177-17232-1-git-send-email-guz.fnst@cn.fujitsu.com>
	<1409735177-17232-5-git-send-email-guz.fnst@cn.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 4/5] pc: add cpu hotplug handler to
 PC_MACHINE
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gu Zheng <guz.fnst@cn.fujitsu.com>
Cc: chen.fan.fnst@cn.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, qemu-devel@nongnu.org, afaerber@suse.de, tangchen@cn.fujitsu.com

On Wed,  3 Sep 2014 17:06:16 +0800
Gu Zheng <guz.fnst@cn.fujitsu.com> wrote:


> diff --git a/qom/cpu.c b/qom/cpu.c
> index b32dd0a..af8e83f 100644
> --- a/qom/cpu.c
> +++ b/qom/cpu.c
> @@ -304,7 +304,6 @@ static void cpu_common_realizefn(DeviceState *dev, Error **errp)
>      if (dev->hotplugged) {
>          cpu_synchronize_post_init(cpu);
>          notifier_list_notify(&cpu_added_notifiers, dev);
^^^ should be dropped as well an hotplug handler should take care about everything this call did.

> -        cpu_resume(cpu);
>      }
>  }
>