From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54974)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1XRidw-0003Ov-MT
	for qemu-devel@nongnu.org; Wed, 10 Sep 2014 10:13:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1XRidr-0001et-7H
	for qemu-devel@nongnu.org; Wed, 10 Sep 2014 10:13:08 -0400
Received: from mx1.redhat.com ([209.132.183.28]:62858)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1XRidr-0001en-09
	for qemu-devel@nongnu.org; Wed, 10 Sep 2014 10:13:03 -0400
Date: Wed, 10 Sep 2014 16:12:53 +0200
From: Igor Mammedov <imammedo@redhat.com>
Message-ID: <20140910161253.718d2b2b@nial.usersys.redhat.com>
In-Reply-To: <1409735177-17232-1-git-send-email-guz.fnst@cn.fujitsu.com>
References: <1409735177-17232-1-git-send-email-guz.fnst@cn.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/5] cpu/acpi: convert cpu hot plug to
 hotplug_handler API
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gu Zheng <guz.fnst@cn.fujitsu.com>
Cc: qemu-devel@nongnu.org, tangchen@cn.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, Bharata B Rao <bharata@linux.vnet.ibm.com>, chen.fan.fnst@cn.fujitsu.com, "Jason J.
	Herne" <jjherne@us.ibm.com>, afaerber@suse.de

On Wed,  3 Sep 2014 17:06:12 +0800
Gu Zheng <guz.fnst@cn.fujitsu.com> wrote:

> 
> Gu Zheng (5):
>   acpi/cpu: add cpu hotplug callback function to match hotplug_handler
>     API
>   acpi:ich9: convert cpu hotplug handle to hotplug_handler API
>   acpi:piix4: convert cpu hotplug handle to hotplug_handler API
>   pc: add cpu hotplug handler to PC_MACHINE
>   cpu/hotplug: remove the left unused cpu hotplug notifier function
> 
>  hw/acpi/cpu_hotplug.c         |   18 ++++++++++++------
>  hw/acpi/ich9.c                |   15 +++------------
>  hw/acpi/piix4.c               |   16 +++-------------
>  hw/i386/pc.c                  |   26 +++++++++++++++++++++++++-
>  include/hw/acpi/cpu_hotplug.h |    6 ++++--
>  include/hw/acpi/ich9.h        |    1 -
>  qom/cpu.c                     |    1 -
>  7 files changed, 47 insertions(+), 36 deletions(-)
> 

Looks like right direction that would allow to drop cpu_added_notifiers
which is not able to pass/handle errors and switch to unified hotplug handler
API which allows to pass errors and would allow to cancel device_add in case of
error.

PS:
Gu Zheng,

Please grep for qemu_register_cpu_added_notifier(), you've missed to convert
rtc usage of CPU notifier.

I'd prefer this to go in before you device_add/add cpu series.