From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59045)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XS8sQ-0004ZE-EX
	for qemu-devel@nongnu.org; Thu, 11 Sep 2014 14:13:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XS8sK-0000QN-9I
	for qemu-devel@nongnu.org; Thu, 11 Sep 2014 14:13:50 -0400
Received: from mx1.redhat.com ([209.132.183.28]:44505)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XS8sK-0000QH-24
	for qemu-devel@nongnu.org; Thu, 11 Sep 2014 14:13:44 -0400
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8BIDhN0028221
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Thu, 11 Sep 2014 14:13:43 -0400
Date: Thu, 11 Sep 2014 21:17:04 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20140911181704.GA29402@redhat.com>
References: <20140911145903.GA27021@redhat.com>
	<1410448873.8604.10.camel@nilsson.home.kraxel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1410448873.8604.10.camel@nilsson.home.kraxel.org>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] ui causes latest master build failure on rhel6
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

On Thu, Sep 11, 2014 at 05:21:13PM +0200, Gerd Hoffmann wrote:
> On Do, 2014-09-11 at 17:59 +0300, Michael S. Tsirkin wrote:
> > I observe two errors with latest master:
> >=20
> > ui/qemu-pixman.c: In function =E2=80=98qemu_pixelformat_from_pixman=E2=
=80=99:
> > ui/qemu-pixman.c:42: error: =E2=80=98PIXMAN_TYPE_RGBA=E2=80=99 undecl=
ared (first use in this function)
> > ui/qemu-pixman.c:42: error: (Each undeclared identifier is reported o=
nly once
> > ui/qemu-pixman.c:42: error: for each function it appears in.)
> > make: *** [ui/qemu-pixman.o] Error 1
>=20
> Guess we need to raise the minimum pixman version in configure ...
>=20
> pixman-0.21.8 is the oldest release which has PIXMAN_TYPE_RGBA.
> We don't check for a minimum version.
> RHEL-6 is probably older.
>=20
> Try 'configure --without-system-pixman' as workaround (after checking
> out the pixman submodule).

I guess but is it a must?
We used to have this within an ifdef:
+#if PIXMAN_VERSION >=3D PIXMAN_VERSION_ENCODE(0, 21, 8)
+            type =3D PIXMAN_TYPE_RGBA;
+#endif
+        }

can't we keep system pixman working a bit longer?


> I'll cook up a patch,
>   Gerd
>=20