From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47021)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1XSA90-0004TS-Ns
	for qemu-devel@nongnu.org; Thu, 11 Sep 2014 15:35:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1XSA8v-0000rg-MW
	for qemu-devel@nongnu.org; Thu, 11 Sep 2014 15:35:02 -0400
Received: from lputeaux-656-01-25-125.w80-12.abo.wanadoo.fr
	([80.12.84.125]:45273 helo=paradis.irqsave.net)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1XSA8v-0000ra-Gj
	for qemu-devel@nongnu.org; Thu, 11 Sep 2014 15:34:57 -0400
Date: Thu, 11 Sep 2014 21:34:00 +0200
From: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>
Message-ID: <20140911193359.GA7305@irqsave.net>
References: <1410336832-22160-1-git-send-email-armbru@redhat.com>
	<1410336832-22160-11-git-send-email-armbru@redhat.com>
	<20140911170604.GA9475@irqsave.net>
	<874mwe7yz7.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <874mwe7yz7.fsf@blackfin.pond.sub.org>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 10/23] block: Eliminate DriveInfo member
 bdrv, use blk_by_legacy_dinfo()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>, kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com

The Thursday 11 Sep 2014 =E0 21:12:44 (+0200), Markus Armbruster wrote :
> Beno=EEt Canet <benoit.canet@irqsave.net> writes:
>=20
> >> +                                   blk_bs(blk_by_legacy_dinfo(dinfo=
)));
> >
> > This seems to be a fairly common pattern: "blk_bs(blk_by_legacy_dinfo=
())".
> > How about a helper function ?
>=20
> Yes, except the pattern is going to evaporate in patch 14 :)

haha