From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48340) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTBNf-0006AM-PV for qemu-devel@nongnu.org; Sun, 14 Sep 2014 11:06:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XTBNZ-0006o7-L3 for qemu-devel@nongnu.org; Sun, 14 Sep 2014 11:06:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33694) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTBNZ-0006nn-EB for qemu-devel@nongnu.org; Sun, 14 Sep 2014 11:06:17 -0400 Date: Sun, 14 Sep 2014 18:09:31 +0300 From: "Michael S. Tsirkin" Message-ID: <20140914150931.GA28042@redhat.com> References: <1410448173-12960-1-git-send-email-kraxel@redhat.com> <1410448173-12960-2-git-send-email-kraxel@redhat.com> <5411BD74.80608@redhat.com> <1410518696.30411.9.camel@nilsson.home.kraxel.org> <20140914134622.GB27315@redhat.com> <20140914141158.GA27836@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers , Dave Airlie , virtio-dev@lists.oasis-open.org, Gerd Hoffmann , "virtualization@lists.linux-foundation.org" On Sun, Sep 14, 2014 at 07:32:21AM -0700, Peter Maydell wrote: > On 14 September 2014 07:11, Michael S. Tsirkin wrote: > > On Sun, Sep 14, 2014 at 07:04:11AM -0700, Peter Maydell wrote: > >> On 14 September 2014 06:46, Michael S. Tsirkin wrote: > >> > BUILD_BUG_ON in linux, QEMU_BUILD_BUG_ON in QEMU. > >> > You have to stick it in a C file though, so it > >> > won't be visible in this patch. > >> > >> Why do you think that? We have several header files which > >> use QEMU_BUILD_BUG_ON and I don't see any reason why > >> it would have to be invoked from a .c file. > > > Because Gerd wants to share this with linux uapi, and > > you can't use BUILD_BUG_ON in uapi headers on linux. > > Who owns the "master" copy of the header and commits > to making sure it builds on other things than Linux+gcc > in that case? > > -- PMM For most of virtio neither linux nor QEMU are the master. syncing them has been done manually in the past. As we are copying other headers from Linux anyway, I think it would be better for everyone if we make the Linux headers the master for QEMU going forward. -- MST