From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40758) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTT5p-0002n1-Da for qemu-devel@nongnu.org; Mon, 15 Sep 2014 06:01:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XTT5k-0001do-Ug for qemu-devel@nongnu.org; Mon, 15 Sep 2014 06:01:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6516) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTT5k-0001da-OD for qemu-devel@nongnu.org; Mon, 15 Sep 2014 06:01:04 -0400 Date: Mon, 15 Sep 2014 12:58:30 +0300 From: "Michael S. Tsirkin" Message-ID: <20140915095830.GB31236@redhat.com> References: <1410244510-9292-1-git-send-email-arei.gonglei@huawei.com> <1410244510-9292-2-git-send-email-arei.gonglei@huawei.com> <20140914181301.GB1226@redhat.com> <33183CC9F5247A488A2544077AF1902086DD32CD@SZXEMA503-MBS.china.huawei.com> <20140915053627.GA6480@redhat.com> <33183CC9F5247A488A2544077AF1902086DD439E@SZXEMA503-MBS.china.huawei.com> <20140915064113.GA31236@redhat.com> <33183CC9F5247A488A2544077AF1902086DD4793@SZXEMA503-MBS.china.huawei.com> <20140915083723.GD6480@redhat.com> <33183CC9F5247A488A2544077AF1902086DD4818@SZXEMA503-MBS.china.huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <33183CC9F5247A488A2544077AF1902086DD4818@SZXEMA503-MBS.china.huawei.com> Subject: Re: [Qemu-devel] [PATCH v2 1/9] virtio-net: use aliases instead of duplicate qdev properties List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Gonglei (Arei)" Cc: "agraf@suse.de" , "peter.crosthwaite@xilinx.com" , "Huangweidong (C)" , Luonengjun , "Huangpeng (Peter)" , "qemu-devel@nongnu.org" , "borntraeger@de.ibm.com" , "stefanha@redhat.com" , "cornelia.huck@de.ibm.com" , "pbonzini@redhat.com" , "afaerber@suse.de" , "rth@twiddle.net" On Mon, Sep 15, 2014 at 09:23:26AM +0000, Gonglei (Arei) wrote: > > > > > > > > > -----Original Message----- > > From: Gonglei (Arei) > > Sent: Monday, September 15, 2014 5:06 PM > > To: 'Michael S. Tsirkin' > > Cc: qemu-devel@nongnu.org; pbonzini@redhat.com; stefanha@redhat.com; > > Huangweidong (C); agraf@suse.de; Huangpeng (Peter); rth@twiddle.net; > > cornelia.huck@de.ibm.com; borntraeger@de.ibm.com; Luonengjun; > > peter.crosthwaite@xilinx.com; afaerber@suse.de > > Subject: RE: [PATCH v2 1/9] virtio-net: use aliases instead of duplicate qdev > > properties > > > > > > > > > > > > > > Sorry, I don't understand your meaning. :( > > > > > > > > > > I applied your patch, and looked at the property types. > > > > > > > > > Could you tell me your method looked at properties type? > > > > > > You can use an HMP command, or you can use > > > -device virtio-net-pci,? > > > > OK. Good method. > > > > > changes must not modify output except for adding > > > new commands, or fixing bugs (with care). > > > > > OK. > > > > > > > They should be netdev/vlan/macaddr. > > > > > Your patch makes them str/int32/str > > > > > > > > > Does those changes have any side-effects? Thanks! > > > > > > Yes. If the types are just "int" and "str" then you > > > have no way to know they should have a specific format, > > > such as a name of a netdev, valid mac address, or a vlan. > > > In fact, vlan=int is a bug since vlan names aren't numbers. > > > > > Got it. > > > > > > The similar changes for virtio-blk had applied in qemu master. > > > > > > > > Best regards, > > > > -Gonglei > > > > > > Which commit? Did output change? If yes it's a bug. > > > > No, I checked it again, virtio-blk-pci's properties are 'int' type as > > the same as virtio-blk device, so it will have no problem on this point. > > > Sorry. There are two properties are different > (commit caffdac363801cd2cf2bf01ad013a8c1e1e43800) > > Before: > > virtio-blk-pci.physical_block_size=blocksize > virtio-blk-pci.logical_block_size=blocksize > > After commit caffdac363801cd2cf2bf01ad013a8c1e1e43800 : > > virtio-blk-pci.physical_block_size=uint16 > virtio-blk-pci.logical_block_size=uint16 So that's a regresion in 2.1.0 Would be nice to fix in stable. > > I will rework this patch series. Thanks a lot for review! :) > > > > Best regards, > > -Gonglei