[Qemu-devel] [PATCH] block/vhdx.c: Mark parent_vhdx_guid variable as unused

[Qemu-devel] [PATCH] block/vhdx.c: Mark parent_vhdx_guid variable as unused

[Peter Maydell]

The parent_vhdx_guid variable is defined but never used, which provokes
complaints from newer versions of clang. Since the variable definition
is here acting as documentation of the image format, mark it with the
'unused' attribute to keep the compiler happy rather than simply
deleting it.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 block/vhdx.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/block/vhdx.c b/block/vhdx.c
index 87c99fc..367a3e7 100644
--- a/block/vhdx.c
+++ b/block/vhdx.c
@@ -99,7 +99,8 @@ static const MSGUID logical_sector_guid = { .data1 = 0x8141bf1d,
 /* Each parent type must have a valid GUID; this is for parent images
  * of type 'VHDX'.  If we were to allow e.g. a QCOW2 parent, we would
  * need to make up our own QCOW2 GUID type */
-static const MSGUID parent_vhdx_guid = { .data1 = 0xb04aefb7,
+static const MSGUID parent_vhdx_guid __attribute__((unused))
+                                     = { .data1 = 0xb04aefb7,
                                          .data2 = 0xd19e,
                                          .data3 = 0x4a81,
                                          .data4 = { 0xb7, 0x89, 0x25, 0xb8,
-- 
2.0.0

Re: [Qemu-devel] [PATCH] block/vhdx.c: Mark parent_vhdx_guid variable as unused

[Fam Zheng]

On Sun, 09/14 20:29, Peter Maydell wrote:
> The parent_vhdx_guid variable is defined but never used, which provokes
> complaints from newer versions of clang. Since the variable definition
> is here acting as documentation of the image format, mark it with the
> 'unused' attribute to keep the compiler happy rather than simply
> deleting it.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  block/vhdx.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/block/vhdx.c b/block/vhdx.c
> index 87c99fc..367a3e7 100644
> --- a/block/vhdx.c
> +++ b/block/vhdx.c
> @@ -99,7 +99,8 @@ static const MSGUID logical_sector_guid = { .data1 = 0x8141bf1d,
>  /* Each parent type must have a valid GUID; this is for parent images
>   * of type 'VHDX'.  If we were to allow e.g. a QCOW2 parent, we would
>   * need to make up our own QCOW2 GUID type */
> -static const MSGUID parent_vhdx_guid = { .data1 = 0xb04aefb7,
> +static const MSGUID parent_vhdx_guid __attribute__((unused))
> +                                     = { .data1 = 0xb04aefb7,
>                                           .data2 = 0xd19e,
>                                           .data3 = 0x4a81,
>                                           .data4 = { 0xb7, 0x89, 0x25, 0xb8,
> -- 
> 2.0.0
> 
> 

Reviewed-by: Fam Zheng <famz@redhat.com>

Re: [Qemu-devel] [PATCH] block/vhdx.c: Mark parent_vhdx_guid variable as unused

[Jeff Cody]

On Sun, Sep 14, 2014 at 08:29:59PM +0100, Peter Maydell wrote:
> The parent_vhdx_guid variable is defined but never used, which provokes
> complaints from newer versions of clang. Since the variable definition
> is here acting as documentation of the image format, mark it with the
> 'unused' attribute to keep the compiler happy rather than simply
> deleting it.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  block/vhdx.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/block/vhdx.c b/block/vhdx.c
> index 87c99fc..367a3e7 100644
> --- a/block/vhdx.c
> +++ b/block/vhdx.c
> @@ -99,7 +99,8 @@ static const MSGUID logical_sector_guid = { .data1 = 0x8141bf1d,
>  /* Each parent type must have a valid GUID; this is for parent images
>   * of type 'VHDX'.  If we were to allow e.g. a QCOW2 parent, we would
>   * need to make up our own QCOW2 GUID type */
> -static const MSGUID parent_vhdx_guid = { .data1 = 0xb04aefb7,
> +static const MSGUID parent_vhdx_guid __attribute__((unused))
> +                                     = { .data1 = 0xb04aefb7,
>                                           .data2 = 0xd19e,
>                                           .data3 = 0x4a81,
>                                           .data4 = { 0xb7, 0x89, 0x25, 0xb8,
> -- 
> 2.0.0
>

Reviewed-by: Jeff Cody <jcody@redhat.com>

Re: [Qemu-devel] [PATCH] block/vhdx.c: Mark parent_vhdx_guid variable as unused

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 611 bytes --]

On Sun, Sep 14, 2014 at 08:29:59PM +0100, Peter Maydell wrote:
> The parent_vhdx_guid variable is defined but never used, which provokes
> complaints from newer versions of clang. Since the variable definition
> is here acting as documentation of the image format, mark it with the
> 'unused' attribute to keep the compiler happy rather than simply
> deleting it.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  block/vhdx.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan

[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]