From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40244) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTV5e-0002IO-D1 for qemu-devel@nongnu.org; Mon, 15 Sep 2014 08:09:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XTV5Z-0000hD-FB for qemu-devel@nongnu.org; Mon, 15 Sep 2014 08:09:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6055) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTV5Z-0000gd-8Y for qemu-devel@nongnu.org; Mon, 15 Sep 2014 08:09:01 -0400 Date: Mon, 15 Sep 2014 08:08:53 -0400 From: Jeff Cody Message-ID: <20140915120853.GA18505@localhost.localdomain> References: <1410722999-17574-1-git-send-email-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1410722999-17574-1-git-send-email-peter.maydell@linaro.org> Subject: Re: [Qemu-devel] [PATCH] block/vhdx.c: Mark parent_vhdx_guid variable as unused List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi , patches@linaro.org On Sun, Sep 14, 2014 at 08:29:59PM +0100, Peter Maydell wrote: > The parent_vhdx_guid variable is defined but never used, which provokes > complaints from newer versions of clang. Since the variable definition > is here acting as documentation of the image format, mark it with the > 'unused' attribute to keep the compiler happy rather than simply > deleting it. > > Signed-off-by: Peter Maydell > --- > block/vhdx.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/block/vhdx.c b/block/vhdx.c > index 87c99fc..367a3e7 100644 > --- a/block/vhdx.c > +++ b/block/vhdx.c > @@ -99,7 +99,8 @@ static const MSGUID logical_sector_guid = { .data1 = 0x8141bf1d, > /* Each parent type must have a valid GUID; this is for parent images > * of type 'VHDX'. If we were to allow e.g. a QCOW2 parent, we would > * need to make up our own QCOW2 GUID type */ > -static const MSGUID parent_vhdx_guid = { .data1 = 0xb04aefb7, > +static const MSGUID parent_vhdx_guid __attribute__((unused)) > + = { .data1 = 0xb04aefb7, > .data2 = 0xd19e, > .data3 = 0x4a81, > .data4 = { 0xb7, 0x89, 0x25, 0xb8, > -- > 2.0.0 > Reviewed-by: Jeff Cody