From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51167)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@nodalink.com>) id 1XTXlE-0003ws-1d
	for qemu-devel@nongnu.org; Mon, 15 Sep 2014 11:00:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benoit.canet@nodalink.com>) id 1XTXl7-0006S1-Gr
	for qemu-devel@nongnu.org; Mon, 15 Sep 2014 11:00:11 -0400
Received: from dew.nodalink.com ([95.130.14.197]:55271)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@nodalink.com>) id 1XTXl7-0006Oe-Bd
	for qemu-devel@nongnu.org; Mon, 15 Sep 2014 11:00:05 -0400
Date: Mon, 15 Sep 2014 15:00:05 +0000
From: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@nodalink.com>
Message-ID: <20140915150005.GA25388@nodalink.com>
References: <1410620427-20089-1-git-send-email-armbru@redhat.com>
	<1410620427-20089-4-git-send-email-armbru@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1410620427-20089-4-git-send-email-armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 03/23] block: Connect BlockBackend to
	BlockDriverState
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, benoit.canet@nodalink.com

> index ff95da6..fa8a7d0 100644
> --- a/qemu-nbd.c
> +++ b/qemu-nbd.c
> @@ -689,7 +689,7 @@ int main(int argc, char **argv)
>      }
>  

>      blk = blk_new("hda", &error_abort);
Is a blk_new_with_bs converssion missing here ?

> -    bs = bdrv_new_root("hda", &error_abort);
> +    bs = blk_bs(blk);
>  
>      srcpath = argv[optind];
>      ret = bdrv_open(&bs, srcpath, NULL, NULL, flags, drv, &local_err);
> -- 
> 1.9.3
>