From: Stefan Hajnoczi <stefanha@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Kevin Wolf <kwolf@redhat.com>, Jeff Cody <jcody@redhat.com>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH] block/vhdx.c: Mark parent_vhdx_guid variable as unused
Date: Mon, 15 Sep 2014 16:45:58 +0100 [thread overview]
Message-ID: <20140915154558.GA32379@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1410722999-17574-1-git-send-email-peter.maydell@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 611 bytes --]
On Sun, Sep 14, 2014 at 08:29:59PM +0100, Peter Maydell wrote:
> The parent_vhdx_guid variable is defined but never used, which provokes
> complaints from newer versions of clang. Since the variable definition
> is here acting as documentation of the image format, mark it with the
> 'unused' attribute to keep the compiler happy rather than simply
> deleting it.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> block/vhdx.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2014-09-15 15:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-14 19:29 [Qemu-devel] [PATCH] block/vhdx.c: Mark parent_vhdx_guid variable as unused Peter Maydell
2014-09-15 1:39 ` Fam Zheng
2014-09-15 12:08 ` Jeff Cody
2014-09-15 15:45 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140915154558.GA32379@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).