From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55622) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTryS-0007LV-1e for qemu-devel@nongnu.org; Tue, 16 Sep 2014 08:35:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XTryK-0000fl-Tu for qemu-devel@nongnu.org; Tue, 16 Sep 2014 08:35:11 -0400 Date: Tue, 16 Sep 2014 08:34:57 -0400 From: Luiz Capitulino Message-ID: <20140916083457.7512ef34@redhat.com> In-Reply-To: <87sijsxc1d.fsf@blackfin.pond.sub.org> References: <20140915140934.17c1bfea@redhat.com> <87sijsxc1d.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] virtio-balloon: fix buffer overflow in memory stats feature List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel , qemu-stable@nongnu.org On Tue, 16 Sep 2014 09:25:02 +0200 Markus Armbruster wrote: > Luiz Capitulino writes: > > > When a QMP client changes the polling interval time by setting > > the guest-stats-polling-interval property, the interval value > > is stored and manipuled as an int64_t variable. > > > > However, the balloon_stats_change_timer() function, which is > > used to set the actual timer with the interval value, takes > > an int instead, causing an overflow for big interval values. > > > > Fix it. > > > > Signed-off-by: Luiz Capitulino > > Subject claims buffer overflow, but description suggests integer > overflow. Which one is it? Integer.