From: Luiz Capitulino <lcapitulino@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>, qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] virtio-balloon: fix buffer overflow in memory stats feature
Date: Tue, 16 Sep 2014 09:44:22 -0400 [thread overview]
Message-ID: <20140916094422.600a65ec@redhat.com> (raw)
In-Reply-To: <87sijrk7f1.fsf@blackfin.pond.sub.org>
On Tue, 16 Sep 2014 15:43:14 +0200
Markus Armbruster <armbru@redhat.com> wrote:
> Luiz Capitulino <lcapitulino@redhat.com> writes:
>
> > On Tue, 16 Sep 2014 09:25:02 +0200
> > Markus Armbruster <armbru@redhat.com> wrote:
> >
> >> Luiz Capitulino <lcapitulino@redhat.com> writes:
> >>
> >> > When a QMP client changes the polling interval time by setting
> >> > the guest-stats-polling-interval property, the interval value
> >> > is stored and manipuled as an int64_t variable.
> >> >
> >> > However, the balloon_stats_change_timer() function, which is
> >> > used to set the actual timer with the interval value, takes
> >> > an int instead, causing an overflow for big interval values.
> >> >
> >> > Fix it.
> >> >
> >> > Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> >>
> >> Subject claims buffer overflow, but description suggests integer
> >> overflow. Which one is it?
> >
> > Integer.
>
> Thanks. If you fix the subject, you can add my R-by.
I've fixed the subject, but I've also added a new hunk to the patch.
prev parent reply other threads:[~2014-09-16 13:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-15 18:09 [Qemu-devel] [PATCH] virtio-balloon: fix buffer overflow in memory stats feature Luiz Capitulino
2014-09-15 19:16 ` Eric Blake
2014-09-15 19:33 ` Luiz Capitulino
2014-09-16 7:25 ` Markus Armbruster
2014-09-16 12:34 ` Luiz Capitulino
2014-09-16 13:43 ` Markus Armbruster
2014-09-16 13:44 ` Luiz Capitulino [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140916094422.600a65ec@redhat.com \
--to=lcapitulino@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).