From: Stefan Hajnoczi <stefanha@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kwolf@redhat.com, geleman@gmail.com, famz@redhat.com,
qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH] aio-win32: avoid out-of-bounds access to the events array
Date: Tue, 16 Sep 2014 11:27:00 +0100 [thread overview]
Message-ID: <20140916102700.GB22174@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1410785578-29277-1-git-send-email-pbonzini@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 661 bytes --]
On Mon, Sep 15, 2014 at 02:52:58PM +0200, Paolo Bonzini wrote:
> If ret is WAIT_TIMEOUT and there was an event returned by select(),
> we can write to a location after the end of the array. But in
> that case we can retry the WaitForMultipleObjects call with the
> same set of events, so just move the event[ret - WAIT_OBJECT_0]
> assignment inside the existin conditional.
>
> Reported-by: TeLeMan <geleman@gmail.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> aio-win32.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2014-09-16 10:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-15 12:52 [Qemu-devel] [PATCH] aio-win32: avoid out-of-bounds access to the events array Paolo Bonzini
2014-09-16 2:21 ` TeLeMan
2014-09-16 10:27 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140916102700.GB22174@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=famz@redhat.com \
--cc=geleman@gmail.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).