From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59377) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XToqb-0007wa-NZ for qemu-devel@nongnu.org; Tue, 16 Sep 2014 05:14:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XToqW-00074N-Ui for qemu-devel@nongnu.org; Tue, 16 Sep 2014 05:14:53 -0400 Date: Tue, 16 Sep 2014 11:12:58 +0200 From: Igor Mammedov Message-ID: <20140916111258.7f842ab8@nial.usersys.redhat.com> In-Reply-To: <1410853532-9956-1-git-send-email-zhang.zhanghailiang@huawei.com> References: <1410853532-9956-1-git-send-email-zhang.zhanghailiang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] vl: Print maxmem in hex format for error message List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: zhanghailiang Cc: qemu-trivial@nongnu.org, luonengjun@huawei.com, qemu-devel@nongnu.org, peter.huangpeng@huawei.com On Tue, 16 Sep 2014 15:45:32 +0800 zhanghailiang wrote: > In error message, maxmem is printed in Dec but ram_size in Hex. > It is better to print them in same format. > Also use error_report instead of fprintf. > > Signed-off-by: zhanghailiang > --- > v2: > - Remove redundant "qemu:" in error message, for error_report already prepend > a variation of "qemu" (comment of Eric Blake) > --- > vl.c | 22 +++++++++++----------- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff --git a/vl.c b/vl.c > index 5db0d08..71a831b 100644 > --- a/vl.c > +++ b/vl.c > @@ -3358,34 +3358,34 @@ int main(int argc, char **argv, char **envp) > > sz = qemu_opt_get_size(opts, "maxmem", 0); > if (sz < ram_size) { > - fprintf(stderr, "qemu: invalid -m option value: maxmem " > - "(%" PRIu64 ") <= initial memory (" > - RAM_ADDR_FMT ")\n", sz, ram_size); > + error_report("invalid -m option value: maxmem " > + "(0x%" PRIx64 ") <= initial memory (0x" > + RAM_ADDR_FMT ")", sz, ram_size); > exit(EXIT_FAILURE); > } > > slots = qemu_opt_get_number(opts, "slots", 0); > if ((sz > ram_size) && !slots) { > - fprintf(stderr, "qemu: invalid -m option value: maxmem " > - "(%" PRIu64 ") more than initial memory (" > + error_report("invalid -m option value: maxmem " > + "(0x%" PRIx64 ") more than initial memory (0x" > RAM_ADDR_FMT ") but no hotplug slots where " > - "specified\n", sz, ram_size); > + "specified", sz, ram_size); > exit(EXIT_FAILURE); > } > > if ((sz <= ram_size) && slots) { > - fprintf(stderr, "qemu: invalid -m option value: %" > + error_report("invalid -m option value: %" > PRIu64 " hotplug slots where specified but " > - "maxmem (%" PRIu64 ") <= initial memory (" > - RAM_ADDR_FMT ")\n", slots, sz, ram_size); > + "maxmem (0x%" PRIx64 ") <= initial memory (0x" > + RAM_ADDR_FMT ")", slots, sz, ram_size); > exit(EXIT_FAILURE); > } > maxram_size = sz; > ram_slots = slots; > } else if ((!maxmem_str && slots_str) || > (maxmem_str && !slots_str)) { > - fprintf(stderr, "qemu: invalid -m option value: missing " > - "'%s' option\n", slots_str ? "maxmem" : "slots"); > + error_report("invalid -m option value: missing " indent error > + "'%s' option", slots_str ? "maxmem" : "slots"); > exit(EXIT_FAILURE); > } > break; with above fixed, Reviewed-By: Igor Mammedov