From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56580) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTs25-0002RW-EI for qemu-devel@nongnu.org; Tue, 16 Sep 2014 08:39:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XTs20-0001Pi-7Z for qemu-devel@nongnu.org; Tue, 16 Sep 2014 08:38:57 -0400 Received: from dew.nodalink.com ([95.130.14.197]:55808) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTs20-0001PM-1t for qemu-devel@nongnu.org; Tue, 16 Sep 2014 08:38:52 -0400 Date: Tue, 16 Sep 2014 12:38:48 +0000 From: =?iso-8859-1?Q?Beno=EEt?= Canet Message-ID: <20140916123848.GA27495@nodalink.com> References: <1410620427-20089-1-git-send-email-armbru@redhat.com> <1410620427-20089-5-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1410620427-20089-5-git-send-email-armbru@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 04/23] block: Connect BlockBackend and DriveInfo List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, benoit.canet@nodalink.com > +DriveInfo *blk_legacy_dinfo(BlockBackend *blk) > +{ > + return blk->legacy_dinfo; > +} > + > +/* > + * Set @blk's DriveInfo to @dinfo, and return it. > + * @blk must not have a DriveInfo set already. > + * No other BlockBackend may have the same DriveInfo set. Must we try to assert this ? This would require an extra linked list traversal but I don't think it's = a performance path anyway. Reviewed-by: Beno=EEt Canet