From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33576)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@nodalink.com>) id 1XTsXh-0007gU-Ff
	for qemu-devel@nongnu.org; Tue, 16 Sep 2014 09:11:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benoit.canet@nodalink.com>) id 1XTsXc-0001aT-3o
	for qemu-devel@nongnu.org; Tue, 16 Sep 2014 09:11:37 -0400
Received: from dew.nodalink.com ([95.130.14.197]:55829)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@nodalink.com>) id 1XTsXb-0001aK-T1
	for qemu-devel@nongnu.org; Tue, 16 Sep 2014 09:11:32 -0400
Date: Tue, 16 Sep 2014 13:04:13 +0000
From: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@nodalink.com>
Message-ID: <20140916130413.GD27495@nodalink.com>
References: <1410620427-20089-1-git-send-email-armbru@redhat.com>
	<1410620427-20089-8-git-send-email-armbru@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <1410620427-20089-8-git-send-email-armbru@redhat.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2 07/23] block: Eliminate bdrv_iterate(),
	use bdrv_next()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, benoit.canet@nodalink.com

> @@ -4717,10 +4699,14 @@ static void monitor_find_completion_by_table(Mo=
nitor *mon,
>              break;
>          case 'B':
>              /* block device name completion */
> -            mbs.mon =3D mon;
> -            mbs.input =3D str;
>              readline_set_completion_index(mon->rs, strlen(str));
> -            bdrv_iterate(block_completion_it, &mbs);
> +            for (bs =3D bdrv_next(NULL); bs; bs =3D bdrv_next(bs)) {
> +                name =3D bdrv_get_device_name(bs);
> +                if (str[0] =3D=3D '\0' ||
> +                    !strncmp(name, str, strlen(str))) {
> +                    readline_add_completion(mon->rs, name);
> +                }
> +            }
>              break;
>          case 's':
>          case 'S':
> --=20
> 1.9.3
>=20
Reviewed-by: Beno=EEt Canet <benoit.canet@nodalink.com>